Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Navigating within the same spread route changes url but page stays the same #688

Closed
btakita opened this issue May 13, 2019 · 2 comments · Fixed by #691
Closed

Navigating within the same spread route changes url but page stays the same #688

btakita opened this issue May 13, 2019 · 2 comments · Fixed by #691

Comments

@btakita
Copy link
Contributor

btakita commented May 13, 2019

I will follow up with a test repo.

For now, I isolated the issue to https://github.com/sveltejs/sapper/blob/master/runtime/src/app/app.ts#L306
@btakita
Copy link
Contributor Author

btakita commented May 13, 2019 •
edited
Loading

@Conduitry Per our Discourse discussion...

Here is the repro branch https://github.com/btakita/business/tree/sapper/issues/688

To repro the issue:

git clone https://github.com/btakita/business.git
cd business
git checkout sapper/issues/688
yarn
cd packages/web
yarn run dev
  • Open localhost:3000
  • Click on one of the top navigation links
  • Click on one of the *.md links in the body
  • The url will change but the page will not update

@btakita
Copy link
Contributor Author

btakita commented May 13, 2019 •
edited
Loading

I have another repro case at https://github.com/ctx-core/sapper-template/tree/sapper/issues/688

This one is a bit simpler.

npx degit ctx-core/sapper-template#sapper/issues/688 my-app
cd my-app
yarn
yarn run dev
  • open localhost:3000
  • click about
  • click 001-about.md link

btakita added a commit to btakita/hbr-sapper that referenced this issue May 13, 2019
@btakita
compare all segments to determine if segment_dirty is true
0526a1e 
Fixes sveltejs#688
This was referenced May 13, 2019
Merged
Closed
btakita added a commit to btakita/hbr-sapper that referenced this issue May 17, 2019
@btakita
Checking the current_branch[i] route match against the current reques…
0c4fbcf 
…t's route match.

current_branch[i].match.slice(1, i+2) compared to match.slice(1, i+2)

Fixes sveltejs#688
btakita added a commit to btakita/hbr-sapper that referenced this issue May 21, 2019
@btakita
Checking the current_branch[i] route match against the current reques…
1455412 
…t's route match.

current_branch[i].match.slice(1, i+2) compared to match.slice(1, i+2)

Fixes sveltejs#688
btakita added a commit to btakita/hbr-sapper that referenced this issue May 21, 2019
@btakita
Checking the current_branch[i] route match against the current reques…
29dc7bb 
…t's route match.

current_branch[i].match.slice(1, i+2) compared to match.slice(1, i+2)

Fixes sveltejs#688
btakita added a commit to btakita/hbr-sapper that referenced this issue May 21, 2019
@btakita
Checking the current_branch[i] route match against the current reques…
7e9e3d1 
…t's route match.

current_branch[i].match.slice(1, i+2) compared to match.slice(1, i+2)

Fixes sveltejs#688
btakita added a commit to btakita/hbr-sapper that referenced this issue May 21, 2019
@btakita
Checking the current_branch[i] route match against the current reques…
ee0189f 
…t's route match.

current_branch[i].match.slice(1, i+2) compared to match.slice(1, i+2)

Fixes sveltejs#688
btakita added a commit to btakita/hbr-sapper that referenced this issue May 21, 2019
@btakita
Checking the current_branch[i] route match against the current reques…
5460896 
…t's route match.

current_branch[i].match.slice(1, i+2) compared to match.slice(1, i+2)

Fixes sveltejs#688
angellikgh pushed a commit to angellikgh/sapper that referenced this issue Jun 9, 2023
@btakita
Checking the current_branch[i] route match against the current reques…
e8dcc6a 
…t's route match.

current_branch[i].match.slice(1, i+2) compared to match.slice(1, i+2)

Fixes sveltejs/sapper#688
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

compare sliced route match to determine if segment_dirty is true btakita/hbr-sapper
1 participant
@btakita