This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
compare sliced route match to determine if segment_dirty is true #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The PR seems to be working with additional tests which failed with the old implementation. The problem was the The bug manifested as the This fix checks the sliced route match array against the sliced route match array in |
btakita
changed the title
btakita
force-pushed
the
issues/688
branch
4 times, most recently
from
7e9e3d1 to
ee0189f
Compare
…t's route match. current_branch[i].match.slice(1, i+2) compared to match.slice(1, i+2) Fixes sveltejs#688
|
I force pushed some formatting fixes. |
|
nice fix, thank you |
This was referenced Sep 2, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #688