Updates to support multiple dotnet targets v3.5, v4.0, v4.5.2, v4.7.2… #415

peracto · 2019-02-06T16:27:51Z

… and dotnetcore2.2

I require dotnetcore2.2 version. While I was in the process, I also added v3.5,v4.0, v4.5.2 and v.4.7.2.
DotnetStandard is a little more complex as it does not fully support System.Drawing.Drawing2D.

In the process I have also updated the tests to support all frameworks.

I have also updated the appveyor.yml script - but don't know how to test it without raising this pull-request. (Is is possible?).

mrbean-bremen · 2019-02-06T17:23:02Z

I require dotnetcore2.2 version. While I was in the process, I also added v3.5,v4.0, v4.5.2 and v.4.7.2.

Yes, that would be nice - I have been playing around with netstandard support in an extra branch, but I'm not familiar with it (I'm more of a C++/Python guy and use C# / .NET only occasionally), so it would be helpful if someone with a bit more experience could have a go at it.

I have also updated the appveyor.yml script - but don't know how to test it without raising this pull-request. (Is is possible?).

Yes - you just have to register yourself at AppVeyor using your Github account, and configure it to run for your branches. This is quite straightforward - let me know if you need any help.

peracto · 2019-02-06T20:16:06Z

It's very frustrating. There are a few issues in the configuration. I'll close the PR and test using my new found AppVeyor account.

mrbean-bremen · 2019-02-06T20:31:30Z

Thanks for looking into this!

peracto · 2019-02-07T09:12:49Z

All tests are now passing. I had to remove net35 from unit testing - I could not get the configuration correct. I have left net35 in the library project - It does compile and pass all unit tests on my local desktop - it was simply an issue with the automated configuration.

As a noob to this whole workflow - I'm still piecing together the whole release cycle. I've been reviewing multiple git/nuget projects, and it seems that there is not a standard method of build-package-release.

For this project, I'm unclear on the nuget process to build and release a package. How is this currently being done ? It does not appear to be in the appveyor CI process. How is the versioning maintained?

Any thoughts and insights would be welcomed.

mrbean-bremen · 2019-02-07T10:16:47Z

@tebjan - could you please answer that (e.g. the release process)? I'm also interested in this...

mrbean-bremen · 2019-02-07T10:22:06Z

Ah, and thanks a lot - this looks quite promising! I will have another look tonight, but I think we can go this way, and add general netstandard support later.
@tebjan, what do you think?

mrbean-bremen

This all looks quite good to me. I added a few remarks and questions, but for me the change looks ok.
~~There are two things I want to clarify with @tebjan before merging:~~
EDIT: can be merged as soon as it is ready.

mrbean-bremen · 2019-02-07T17:50:24Z

Source/Properties/AssemblyInfo.cs

@@ -1,4 +1,5 @@
 using System;
+#if __EXCLUDED__


Where do you define this? I would have expected this to be defined for .netcore, but I couldn't find it.

This was me being lazy. I wanted to keep reference to it - it was a lazy way to comment it out.

mrbean-bremen · 2019-02-07T17:54:02Z

Source/Svg.csproj

@@ -1,393 +1,145 @@
-<?xml version="1.0" encoding="utf-8"?>
-<Project DefaultTargets="Build" xmlns="http://schemas.microsoft.com/developer/msbuild/2003" ToolsVersion="4.0">
+<Project Sdk="Microsoft.NET.Sdk">


This has been introduced in MSBuild 15, so I guess we need VS 2017 to build this, right?

You are probably correct. It was something that I did not consider when making the changes.

mrbean-bremen · 2019-02-07T17:59:34Z

Source/Svg.csproj

+    <PackageRequireLicenseAcceptance>true</PackageRequireLicenseAcceptance>
+    <PackageReleaseNotes>
+Supports multiple targets v3.5 thru to dotnetcore2.2. 
+NetStandard does not fully support the Drawing2D package - so has been left out.


From what I understood, the next (yet unreleased) netstandard 2.1 version will support all of Drawing2D - the interface is already there. I hope that that means that the respective implementations will support this soon, but I couldn't find any specifics as to when this will be.

Again, you are probably correct. I did make an effort to get it working, but rather than spend time hacking a solution, I thought it better to wait for the platform to catch up.
My main focus was to amend the CI/CD process to support multiple targets. Once netstandard catches up, it should simply slot in.

Agreed. Maybe we don't have to wait long for that.

mrbean-bremen · 2019-02-07T18:03:19Z

Source/Web/SvgHandler.cs

@@ -1,3 +1,4 @@
+#if __EXCLUDED__


so, __EXCLUDED__ actually means "Web included", or did I misunderstand this? Shouldn't the web part be included for .NET implementations?

Again, me being lazy. There are a number of components that would not compile - and it was easier to remove the whole.
In retrospect, I should leave it enabled for the version of dotnet that support it. I'll review it tomorrow.

Ok, thanks!

mrbean-bremen · 2019-02-07T18:09:38Z

Tests/Svg.UnitTests/ImageComparisonTest.cs

@@ -13,6 +15,32 @@ namespace Svg.UnitTests
    public class ImageComparisonTest
    {
        public TestContext TestContext { get; set; }
+#if NETCORE
+        private static string _basePath = null;
+        private static string GetSuiteTestsFolder


Wouldn't this also work for the .NET case?

It may work - I'll perform the tests tomorrow.

That would be nice - I cobbled that test code together to work somehow, but it is not very robust and I don't really like it.

mrbean-bremen · 2019-02-19T18:57:03Z

@peracto - are you still working on this? Do you need help here? I think with the few changes you wanted to do, and after clarifying the issue with VS 2017 with @tebjan, we could merge this.

@tebjan - this would be a first step to netstandard compatibility, and the only caveat is that you need VS 2017 to build it (seems to be needed for proper multi-target support). What do think?

mrbean-bremen · 2019-02-27T18:53:27Z

@peracto - @tebjan is ok with the need for VS2017, do you need any help to finish this PR (and maybe resolving the conflict)?

mrbean-bremen · 2019-03-05T21:17:30Z

@peracto - I have resolved the conflicts and put them into an extra branch, just in case you are working on this one. Please let us know what the state of this PR is - if you don't have the time to work on this, I can just continue.

bloodwiing · 2019-03-06T19:06:59Z

@mrbean-bremen Cool. So we can use that one until the branch merges?
If so then could you be kind as to explain on the branched packages installation steps? 😅 Thank you very much.

mrbean-bremen · 2019-03-06T19:54:48Z

Sorry, no instructions so far - as you can see above, I also don't know how to package this. I'm just compiling and testing it manually / via CI.
Though I'm going to have a closer look at the packaging - looks like this should not be complicated - but not before the weekend, I'm a bit short on time currently.

bloodwiing · 2019-03-06T19:58:41Z

Ah I see. I still appreciate your work and effort 😃

Though I'm going to have a closer look at the packaging - looks like this should not be complicated - but not before the weekend, I'm a bit short on time currently.

Could you tell when that happens? Can't wait 😛

gvheertum · 2019-03-07T11:40:44Z

@thedonciuxx @mrbean-bremen
Looking at the source I guess it's just calling a "nuget pack" after you performed a release build. The Nuget folder contains the nuspec file which has the specs for the nuget file to be created. Pushing it to the nuget feed might be a different thing, since that might require an API key or rights on the repository.

@thedonciuxx If you want to quickly use the branched version, I suggest downloading/forking the sources @mrbean-bremen refers to and roll your own build. You will only need the Svg.dll to include in your project. From what I see, no special actions are performed in the package install, just a copy and link of the dll, xml (doc) and pdb (debug) files, so I think waiting for a package is not really necessary.

… and dotnetcore2.2

…top.

mrbean-bremen · 2019-05-06T19:34:47Z

This is continued in #448, as the owner of this branch is not active anymore, and this had some conflicts that have been difficult to resolve.

peracto closed this Feb 6, 2019

peracto reopened this Feb 7, 2019

mrbean-bremen approved these changes Feb 7, 2019

View reviewed changes

mrbean-bremen mentioned this pull request Feb 9, 2019

Support for .NET Core #400

Closed

mrbean-bremen mentioned this pull request Mar 3, 2019

Svg on opening loads nothing in .NET Core 2.2 #427

Closed

garyranson and others added 11 commits April 8, 2019 20:05

Updates to support multiple dotnet targets v3.5, v4.0, v4.5.2, v4.7.2…

4c20810

… and dotnetcore2.2

Added nugget restore to appveyor build

1fc7835

Appveyor build solution

77ccedf

Appvery attempt 3

e178397

Appveyor attempt 3a

5259022

Add explict FrameworkPathOverride to project. Seems to work from desk…

bb871e3

…top.

added <IsTextProject> to csproj file

fefb108

Add FrameworkPathOverride to UnitTest project

e46874a

Update appveyor.yml

416b732

Remove net35 from unittests. Updated licence method.

880a93d

Fixed merge problems in image comparison test

7351edf

mrbean-bremen mentioned this pull request Apr 26, 2019

兼容 netcoreapp2.2 与 NET35 版本,解决错误解析 "ul ol+li{fill:#000000;font-family:ZWBIQX+HelveticaUnicodeMS;}" 的bug #442

Closed

mrbean-bremen mentioned this pull request May 6, 2019

Updates to support multiple dotnet targets #448

Closed

mrbean-bremen closed this May 6, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updates to support multiple dotnet targets v3.5, v4.0, v4.5.2, v4.7.2… #415

Updates to support multiple dotnet targets v3.5, v4.0, v4.5.2, v4.7.2… #415

peracto commented Feb 6, 2019

mrbean-bremen commented Feb 6, 2019

peracto commented Feb 6, 2019

mrbean-bremen commented Feb 6, 2019

peracto commented Feb 7, 2019

mrbean-bremen commented Feb 7, 2019

mrbean-bremen commented Feb 7, 2019

mrbean-bremen left a comment •

edited

Loading

mrbean-bremen Feb 7, 2019

peracto Feb 7, 2019

mrbean-bremen Feb 7, 2019

peracto Feb 7, 2019

mrbean-bremen Feb 7, 2019

peracto Feb 7, 2019

mrbean-bremen Feb 7, 2019

mrbean-bremen Feb 7, 2019

peracto Feb 7, 2019

mrbean-bremen Feb 7, 2019

mrbean-bremen Feb 7, 2019

peracto Feb 7, 2019

mrbean-bremen Feb 7, 2019

mrbean-bremen commented Feb 19, 2019

mrbean-bremen commented Feb 27, 2019

mrbean-bremen commented Mar 5, 2019

bloodwiing commented Mar 6, 2019

mrbean-bremen commented Mar 6, 2019

bloodwiing commented Mar 6, 2019 •

edited

Loading

gvheertum commented Mar 7, 2019

mrbean-bremen commented May 6, 2019

Updates to support multiple dotnet targets v3.5, v4.0, v4.5.2, v4.7.2… #415

Updates to support multiple dotnet targets v3.5, v4.0, v4.5.2, v4.7.2… #415

Conversation

peracto commented Feb 6, 2019

mrbean-bremen commented Feb 6, 2019

peracto commented Feb 6, 2019

mrbean-bremen commented Feb 6, 2019

peracto commented Feb 7, 2019

mrbean-bremen commented Feb 7, 2019

mrbean-bremen commented Feb 7, 2019

mrbean-bremen left a comment • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mrbean-bremen commented Feb 19, 2019

mrbean-bremen commented Feb 27, 2019

mrbean-bremen commented Mar 5, 2019

bloodwiing commented Mar 6, 2019

mrbean-bremen commented Mar 6, 2019

bloodwiing commented Mar 6, 2019 • edited Loading

gvheertum commented Mar 7, 2019

mrbean-bremen commented May 6, 2019

mrbean-bremen left a comment •

edited

Loading

bloodwiing commented Mar 6, 2019 •

edited

Loading