Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updates to support multiple dotnet targets #448

Closed
wants to merge 2 commits into from
Closed

Updates to support multiple dotnet targets #448

wants to merge 2 commits into from

Conversation

mrbean-bremen
Copy link
Member

  • support v3.5, v4.0, v4.5.2, v4.7.2 and dotnetcore2.2
  • added support for Appveyor build

@mrbean-bremen
Copy link
Member Author

This is the continuation of #415, rebased with current version, fixed some merge errors and problems with excluded code. This is still work in progress.

@mrbean-bremen mrbean-bremen mentioned this pull request May 6, 2019
Closed
@mrbean-bremen mrbean-bremen force-pushed the netcore branch 2 times, most recently from ab03771 to d45ddb0 Compare May 8, 2019 17:54
@mrbean-bremen
Copy link
Member Author

@tebjan - this seems to work basically, at least under Windows - for a problem under Linux there is a separate issue.
I won't wait anymore for the original author for merging - support for Linux and for NetStandard can be added later - but I would like you to check and try this PR to make sure nothing is broken or missing before merging.

@tebjan
Copy link
Contributor

tebjan commented May 8, 2019

looks good to me. i am just wondering why there is the need for so many .net frameworks. since the lowest version will work with any project that targets this or a newer framework.

@mrbean-bremen
Copy link
Member Author

Good question - I actually don't know.
Currently, the unit tests in AppVeyor work only with .NET 4.5 and higher, and in .NETCore, due to the MS test framework, but that is not a real reason...

@mrbean-bremen
Copy link
Member Author

Actually, I will just remove the unneeded versions, leaving only .NET 3.5 and .NETCore - you are right, this is not needed, I just hadn't questioned that...

@mrbean-bremen
Copy link
Member Author

Ok, I amended the last commit accordingly.

@tebjan
Copy link
Contributor

tebjan commented May 8, 2019

it doesn't hurt either. so, i think you can leave the 4.5 if it helps to have the tests running.

@mrbean-bremen
Copy link
Member Author

The tests also run with 3.5 - only the unit test project itself has to be 4.5, so this is not an issue.

@tebjan
Copy link
Contributor

tebjan commented May 8, 2019

ping me if you think it's ready for another nuget release.

@chucker
Copy link
Contributor

chucker commented May 9, 2019

This is still work in progress.

this seems to work basically, at least under Windows

Anything in particular others can help on?

@mrbean-bremen
Copy link
Member Author

Anything in particular others can help on?

Yes - make it work under Linux :)
If have not tested it myself, but there is at least #427 that needs fixing - any help is welcome!

garyranson and others added 2 commits May 9, 2019 19:58
@garyranson @mrbean-bremen
Updates to support multiple dotnet targets
fffd44f 
- support v3.5, v4.0, v4.5.2, v4.7.2 and dotnetcore2.2
- added support for Appveyor build
- added explict FrameworkPathOverride to projects
- added <IsTextProject> to csproj file
- remove net35 from unittests. Updated licence method.
@mrbean-bremen
Fixed merge problems in image comparison test
e0ff56e 
- removed / replaced EXCLUDE defines
- added back System.Web
- added back projects for SVG viewer and test runner
- added back AssemblyInfo, no not generate it in .NETCore
- removed FrameworkPathOverride - seems not to work correctly with current version
- removed unneeded framework versions
@chucker
Copy link
Contributor

chucker commented May 9, 2019

I made a pull request for this. Unfortunately, I couldn't figure out how to make a pull request consisting only of my change, so I made it separately at #450.

@mrbean-bremen
Copy link
Member Author

I made a pull request for this. Unfortunately, I couldn't figure out how to make a pull request consisting only of my change, so I made it separately at #450.

I should have merged back first... well, I will use yours instead, thanks a lot!

@mrbean-bremen
Copy link
Member Author

Closing - will use the new PR instead.

@mrbean-bremen mrbean-bremen deleted the netcore branch May 26, 2019 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mrbean-bremen @tebjan @chucker @garyranson