Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor prefixIds #1561

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Refactor prefixIds #1561

merged 3 commits into from
Sep 13, 2021

Conversation

TrySound
Copy link
Member

@TrySound TrySound commented Sep 9, 2021

cc @strarsis

@TrySound
Copy link
Member Author

TrySound commented Sep 9, 2021

Looks like the error is caused by this
nodejs/node#40030

@TrySound
Copy link
Member Author

Build is fixed!

Ref #1499

- migrated to visitor plugin api
- covered with tsdoc
- made the plugin idempotent as requested a few times
  Now even manually running svgo a few times will not duplicate
  prefix in ids and classes
- run each plugin test twice to see which plugin need to run many times
  ideally idempotent plugins will allow to get rid of multipass option in v3
@TrySound TrySound merged commit 3d22a5b into master Sep 13, 2021
@TrySound TrySound deleted the refactor-prefix-ids branch September 13, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants