Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor prefixIds #1561

Merged
merged 3 commits into from
Sep 13, 2021
Merged

Refactor prefixIds #1561

merged 3 commits into from
Sep 13, 2021

Commits on Sep 12, 2021

  1. Refactor prefixIds 

    Ref #1499

- migrated to visitor plugin api
- covered with tsdoc
- made the plugin idempotent as requested a few times
  Now even manually running svgo a few times will not duplicate
  prefix in ids and classes
- run each plugin test twice to see which plugin need to run many times
  ideally idempotent plugins will allow to get rid of multipass option in v3
    @TrySound
    TrySound committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    0d948b6 View commit details
    Browse the repository at this point in the history

  2. Fix basename when path has no slashes

    @TrySound
    TrySound committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    cfeb2e4 View commit details
    Browse the repository at this point in the history

  3. Remove unnecessary check

    @TrySound
    TrySound committed Sep 12, 2021
    Configuration menu
    Copy the full SHA
    684cce6 View commit details
    Browse the repository at this point in the history