Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(styling): Ensure authorize button stays on the right for UX reasons #9387

Merged

Conversation

pedoch
Copy link
Contributor

@pedoch pedoch commented Nov 16, 2023

Ensure that the Authorize button stays on the right when Server and Schemes selectors are not present.

Refs #8940

Description

This is a fix for an issue caused by this PR #9325. You can find details about the issue here.

Motivation and Context

This will stop the awkwardness of having the Authorize button on the left (users are used to having it on the right).

How Has This Been Tested?

I tested these style changes using multiple devices on multiple platforms with different screen sizes.
Also, because these are just styling changes no new tests are needed and all existing tests pass.

Screenshots (if appropriate):

Screenshot from 2023-11-16 12-13-26

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

@pedoch pedoch changed the title Fix(styling): Ensure authorize button stays on the left for UX reasons Fix(styling): Ensure authorize button stays on the right for UX reasons Nov 16, 2023
@pedoch pedoch force-pushed the bug/fix-operation-page-responsiveness branch from 82557be to 9f8e5b6 Compare November 16, 2023 11:35
@char0n char0n self-requested a review November 20, 2023 10:39
@char0n char0n self-assigned this Nov 20, 2023
Copy link
Member

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the followup regression fix. I've verified locally that this fix works as expected.

@char0n char0n merged commit 8f93354 into swagger-api:master Nov 20, 2023
6 checks passed
@ahorek ahorek mentioned this pull request Dec 6, 2023
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants