Contexts that can be serialized + deserialized while retaining and explicitly representing sharing #2202
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Not quite ready to merge --- still need to update more JSON instances --- but I would be happy to get any comments or questions at this point! I've tried to put in a bunch of comments but it's quite possible, even likely, that it's still confusing. Please let me know and I will happily add more comments or clarify anything that's confusing. |
xsebek
reviewed
Nov 5, 2024
xsebek
reviewed
Nov 5, 2024
Co-authored-by: Restyled.io <commits@restyled.io>
kostmo
approved these changes
Nov 21, 2024
xsebek
reviewed
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #2107. Instead of simply storing a
Map, contexts now also store a structured tree representing how it was built, and cache homomorphic hash values so contexts can be compared + stored by hash. This allows us to serialize contexts into a compact form that never duplicates any context, then deserialize them in a way that restores all the sharing.The big thing that is left is to make
FromJSONEinstances forValueandEnv(and anything which contains them). I was working on these but got bogged down, so decided to not let the perfect be the enemy of the good. You can see some commented-out code towards aFromJSONE Valueinstance. But we don't use any such instances yet, so I think this can be merged as is, and the rest worked out later.