Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(es/ast): Improve type definitions of patterns #8532

Merged
merged 443 commits into from
Feb 5, 2024
Merged

refactor(es/ast): Improve type definitions of patterns #8532

merged 443 commits into from
Feb 5, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 21, 2024

Description:

  • Copy AssignmentTarget from oxc.
  • Use BindingIdentifier in more places.

Related issue:

@kdy1 kdy1 requested review from a team as code owners January 21, 2024 03:09
@kdy1 kdy1 marked this pull request as draft January 21, 2024 03:09
@kdy1 kdy1 self-assigned this Jan 29, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: def84d4

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review January 30, 2024 02:11
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 30, 2024
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 30, 2024
View reviewed changes
@kdy1 kdy1 requested review from kwonoj and magic-akari January 30, 2024 02:12
kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 30, 2024
View reviewed changes
kdy1
kdy1 commented Jan 30, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_common
  • swc_ecma_ast --breaking

kodiakhq[bot]
kodiakhq bot previously approved these changes Jan 30, 2024
View reviewed changes
@kdy1 kdy1 closed this Jan 30, 2024
@kdy1 kdy1 deleted the oxc-ast2 branch January 30, 2024 04:43
@kdy1 kdy1 restored the oxc-ast2 branch January 30, 2024 04:43
@kdy1 kdy1 reopened this Jan 30, 2024
@kdy1 kdy1 requested a review from Austaras January 30, 2024 04:44
@kdy1 kdy1 enabled auto-merge (squash) February 5, 2024 06:15
@kdy1 kdy1 disabled auto-merge February 5, 2024 06:32
@kdy1 kdy1 merged commit 7f2a2c1 into swc-project:main Feb 5, 2024
141 checks passed
@kdy1 kdy1 deleted the oxc-ast2 branch February 5, 2024 06:32
This was referenced Feb 5, 2024
Merged
Merged
Merged
kdy1 added a commit to vercel/turborepo that referenced this pull request Feb 13, 2024
@kdy1
build: Update swc_core to v0.90.7 (#7272)
6701909 
### Description

Update swc crates to apply swc-project/swc#8532 and other bugfixes


### Testing Instructions

next.js counterpart: vercel/next.js#61662

Closes PACK-2390
kdy1 added a commit to vercel/next.js that referenced this pull request Feb 13, 2024
@kdy1
Update swc_core to v0.90.7 and update turbopack (#61662)
42872bf 
# Turbopack changes

* vercel/turborepo#7342 <!-- OJ Kwon - docs(turbopack): build, deploy rustdocs -->
* vercel/turborepo#7356 <!-- OJ Kwon - ci(workflow): remove doc deploy -->
* vercel/turborepo#7272 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.90.7` -->


### What?

Update swc crates

### Why?

- To apply swc-project/swc#8532 and other bugfixes

### How?

 - Closes PACK-2389
 - Closes PACK-2446
 - Closes #61788
@Boshen Boshen mentioned this pull request Feb 27, 2024
Closed
1 task
@swc-project swc-project locked as resolved and limited conversation to collaborators Mar 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

@kwonoj kwonoj Awaiting requested review from kwonoj

@magic-akari magic-akari Awaiting requested review from magic-akari

@Austaras Austaras Awaiting requested review from Austaras

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Concise design from oxc: AssignmentTarget
1 participant
@kdy1