Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(es/typescript): Add esm build for fast ts strip #9286

Merged
merged 1 commit into from
Jul 20, 2024

Conversation

magic-akari
Copy link
Member

Related issue (if exists):

Copy link

changeset-bot bot commented Jul 19, 2024

⚠️ No Changeset found

Latest commit: 8c8a0fe

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@magic-akari magic-akari marked this pull request as ready for review July 19, 2024 11:31
@magic-akari magic-akari requested a review from a team as a code owner July 19, 2024 11:31
@kdy1
Copy link
Member

kdy1 commented Jul 19, 2024

How will this work while publishing? I think this will add esm Wasm binary to the original package, right?
I think it may cause an issue for node.js team due to the size of the binary. Can we have another entry at

settings:
- crate: "binding_core_wasm"
npm: "@swc\\/wasm"
target: nodejs
- crate: "binding_core_wasm"
npm: "@swc\\/wasm-web"
target: web
- crate: "binding_typescript_wasm"
npm: "@swc\\/wasm-typescript"
target: nodejs
instead?

@kdy1 kdy1 added this to the Planned milestone Jul 19, 2024
Copy link

codspeed-hq bot commented Jul 19, 2024

CodSpeed Performance Report

Merging #9286 will not alter performance

Comparing magic-akari:feat/ts-strip/esm (8c8a0fe) with main (76fe139)

Summary

✅ 178 untouched benchmarks

@magic-akari
Copy link
Member Author

How will this work while publishing? I think this will add esm Wasm binary to the original package, right? I think it may cause an issue for node.js team due to the size of the binary. Can we have another entry at

settings:
- crate: "binding_core_wasm"
npm: "@swc\\/wasm"
target: nodejs
- crate: "binding_core_wasm"
npm: "@swc\\/wasm-web"
target: web
- crate: "binding_typescript_wasm"
npm: "@swc\\/wasm-typescript"
target: nodejs

instead?

I agree.

@magic-akari magic-akari marked this pull request as draft July 19, 2024 15:01
@magic-akari
Copy link
Member Author

I tweaked the CI logic.
This is the most troublesome because I don't know if it will work the first time.

@magic-akari magic-akari marked this pull request as ready for review July 20, 2024 12:41
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll try using nightly

@kdy1 kdy1 enabled auto-merge (squash) July 20, 2024 12:42
@kdy1 kdy1 merged commit d10cb9f into swc-project:main Jul 20, 2024
154 checks passed
@magic-akari magic-akari deleted the feat/ts-strip/esm branch July 20, 2024 12:55
@kdy1 kdy1 modified the milestones: Planned, v1.7.1 Jul 23, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add ESM exports to @swc/wasm-typescript
2 participants