Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(visit): Fix regression of AST paths #9420

Merged
merged 16 commits into from
Aug 12, 2024
Merged

fix(visit): Fix regression of AST paths #9420

merged 16 commits into from
Aug 12, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 12, 2024

Description:

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Aug 12, 2024
Copy link

changeset-bot bot commented Aug 12, 2024

🦋 Changeset detected

Latest commit: d4b0999

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1
Copy link
Member Author

kdy1 commented Aug 12, 2024

Bisect

Copy link

codspeed-hq bot commented Aug 12, 2024

CodSpeed Performance Report

Merging #9420 will degrade performances by 4.23%

Comparing kdy1:bisect (d4b0999) with main (34d1b27)

Summary

❌ 2 regressions
✅ 176 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:bisect Change
es/full/bugs-1 531.3 µs 554.8 µs -4.23%
es/visitor/base-perf/boxing_boxed_clone 2.3 µs 2.4 µs -3.72%

@kdy1 kdy1 changed the title fix(es): Fix regression fix(visit): Fix regression of AST paths Aug 12, 2024
@kdy1 kdy1 marked this pull request as ready for review August 12, 2024 04:49
@kdy1 kdy1 requested review from a team as code owners August 12, 2024 04:49
@kdy1 kdy1 requested review from a team as code owners August 12, 2024 04:49
@kdy1 kdy1 enabled auto-merge (squash) August 12, 2024 04:49
@kdy1 kdy1 disabled auto-merge August 12, 2024 05:09
@kdy1 kdy1 merged commit 9751518 into swc-project:main Aug 12, 2024
153 checks passed
@kdy1 kdy1 deleted the bisect branch August 12, 2024 05:09
@kdy1 kdy1 modified the milestones: Planned, v1.7.11 Aug 14, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant