Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/ast): Make span of binding ident include type ann #9293

Merged
merged 4 commits into from
Jul 19, 2024

Conversation

dsherret
Copy link
Contributor

Description:

The binding ident includes a type ann and should have the type ann in it.

Related issue (if exists): #9290

@dsherret dsherret requested a review from a team as a code owner July 19, 2024 16:08
Copy link

changeset-bot bot commented Jul 19, 2024

🦋 Changeset detected

Latest commit: 2d31892

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 changed the title fix(ast): span of binding ident should include type ann fix(es/ast): MAke span of binding ident include type ann Jul 19, 2024
kdy1
kdy1 previously approved these changes Jul 19, 2024
@kdy1 kdy1 changed the title fix(es/ast): MAke span of binding ident include type ann fix(es/ast): Make span of binding ident include type ann Jul 19, 2024
@kdy1 kdy1 requested a review from a team as a code owner July 19, 2024 16:35
@kdy1 kdy1 enabled auto-merge (squash) July 19, 2024 16:36
@kdy1 kdy1 added this to the Planned milestone Jul 19, 2024
@kdy1 kdy1 merged commit 2b32481 into swc-project:main Jul 19, 2024
154 checks passed
Copy link

codspeed-hq bot commented Jul 19, 2024

CodSpeed Performance Report

Merging #9293 will not alter performance

Comparing dsherret:fix_span_binding_ident (2d31892) with dsherret:fix_span_binding_ident (bdbf4d9)

Summary

✅ 178 untouched benchmarks

@dsherret dsherret deleted the fix_span_binding_ident branch July 19, 2024 19:35
@kdy1 kdy1 modified the milestones: Planned, v1.7.1 Jul 23, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants