Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Fix analysis of for-in/of #9340

Merged
merged 6 commits into from
Jul 29, 2024
Merged

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 29, 2024

@kdy1 kdy1 added this to the Planned milestone Jul 29, 2024
@kdy1 kdy1 self-assigned this Jul 29, 2024
@kdy1 kdy1 requested a review from a team as a code owner July 29, 2024 03:13
kodiakhq[bot]
kodiakhq bot previously approved these changes Jul 29, 2024
Copy link

changeset-bot bot commented Jul 29, 2024

🦋 Changeset detected

Latest commit: 14eb882

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 requested a review from a team as a code owner July 29, 2024 03:13
@kdy1 kdy1 enabled auto-merge (squash) July 29, 2024 03:14
@kdy1 kdy1 merged commit 1454ab5 into swc-project:main Jul 29, 2024
154 checks passed
@kdy1 kdy1 deleted the issue-9263 branch July 29, 2024 04:05
Copy link

codspeed-hq bot commented Jul 29, 2024

CodSpeed Performance Report

Merging #9340 will degrade performances by 3.02%

Comparing kdy1:issue-9263 (14eb882) with kdy1:issue-9263 (2d6a201)

Summary

❌ 1 regressions
✅ 177 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark kdy1:issue-9263 kdy1:issue-9263 Change
es/full/bugs-1 538.3 µs 555.1 µs -3.02%

@kdy1 kdy1 modified the milestones: Planned, v1.7.4 Jul 31, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

minifier: cannot detect variable's value changed without using assignment operator
1 participant