Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(common): Remove dbg log #9384

Merged
merged 2 commits into from
Aug 6, 2024

Conversation

stormslowly
Copy link
Contributor

Description:

after upgrade to swc_core 0.100.1 logs of debug logs like this

[/...xxx.../swc_common-0.37.0/src/source_map.rs:1369:13] &token = <Token ../../../node_modules/.pnpm/antd@5.18.0_react-dom@18.2.0_react@18.2.0/node_modules/antd/es/cascader/index.js:151:2 (6779:16)>

BREAKING CHANGE:

No

Related issue (if exists):

@stormslowly stormslowly requested a review from a team as a code owner August 6, 2024 10:31
Copy link

changeset-bot bot commented Aug 6, 2024

🦋 Changeset detected

Latest commit: dd76d95

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, thank you!

@kdy1 kdy1 changed the title chore: 🔥 remove dbg log chore(common): Remove dbg log Aug 6, 2024
@kdy1 kdy1 merged commit a538ca1 into swc-project:main Aug 6, 2024
5 checks passed
@kdy1 kdy1 modified the milestones: Planned, 1.7.7 Aug 6, 2024
@stormslowly
Copy link
Contributor Author

when will publish the new swc_commom and swc_core ?
lots of logs in our CI system : (

@kdy1
Copy link
Member

kdy1 commented Aug 6, 2024

It's already published.
35afd13

You can do cargo update -p swc_common to update your dependency

Copy link

codspeed-hq bot commented Aug 6, 2024

CodSpeed Performance Report

Merging #9384 will improve performances by 3.85%

Comparing stormslowly:chore/remove_dbg_log (07bc839) with main (a538ca1)

Summary

⚡ 1 improvements
✅ 177 untouched benchmarks

Benchmarks breakdown

Benchmark main stormslowly:chore/remove_dbg_log Change
parse_and_babelify_backbone 18.5 ms 17.8 ms +3.85%

@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 6, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants