Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(es/plugin): Make analyze_source_file lazy, again #9732

Merged
merged 4 commits into from
Nov 11, 2024
Merged

perf(es/plugin): Make analyze_source_file lazy, again #9732

merged 4 commits into from
Nov 11, 2024
+173 −40

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 11, 2024

Description:

This reverts commit 772f023.

Related issue:

@kdy1 kdy1 added this to the Planned milestone Nov 11, 2024
@kdy1 kdy1 self-assigned this Nov 11, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Nov 11, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 1113fb9

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review November 11, 2024 12:22
@kdy1 kdy1 requested a review from a team as a code owner November 11, 2024 12:22
@kdy1 kdy1 merged commit c1d12d6 into swc-project:main Nov 11, 2024
151 of 152 checks passed
@kdy1 kdy1 deleted the common-lazy branch November 11, 2024 12:22
kdy1 added a commit to kdy1/swc that referenced this pull request Nov 11, 2024
@kdy1
Revert "perf(es/plugin): Make analyze_source_file lazy, again (swc-…
741c454 
…project#9732)"

This reverts commit c1d12d6.
@kdy1 kdy1 mentioned this pull request Nov 11, 2024
Merged
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Nov 11, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9732 will improve performances by 9.37%

Comparing kdy1:common-lazy (1113fb9) with main (9b74ccd)

Summary

⚡ 11 improvements
✅ 183 untouched benchmarks

Benchmarks breakdown

Benchmark main kdy1:common-lazy Change
⚡ es/full/base/fixer 128.6 µs 117.6 µs +9.37%
⚡ es/full/all/es2015 193.4 ms 185.2 ms +4.4%
⚡ es/full/all/es2016 191.7 ms 183.9 ms +4.22%
⚡ es/full/all/es2017 191.2 ms 183.2 ms +4.37%
⚡ es/full/all/es2018 189.5 ms 181.7 ms +4.26%
⚡ es/full/all/es2019 188.6 ms 180.8 ms +4.3%
⚡ es/full/all/es2020 181.8 ms 173.8 ms +4.64%
⚡ es/full/all/es3 258.1 ms 250 ms +3.25%
⚡ es/full/all/es5 251.6 ms 243.2 ms +3.46%
⚡ es/full/parser 1.5 ms 1.4 ms +8.56%
⚡ es/visitor/base-perf/boxing_unboxed_clone 2.6 µs 2.6 µs +3.43%

kdy1 added a commit that referenced this pull request Nov 11, 2024
@kdy1
refactor: Delay Wasm-plugin breaking changes (#9735)
92faf5b 
**Related issue:**

 - Reverts #9732
 - Reverts #9731
 - Reverts #9730
@kdy1 kdy1 modified the milestones: Planned, 1.9.3 Nov 22, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
1.9.3
Development

Successfully merging this pull request may close these issues.
1 participant
@kdy1