Add new LambdaRuntime #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
reviewed
Sep 4, 2024
Comment on lines
48
to
54
|
|
||
| /// The default EventLoop the Lambda is scheduled on. | ||
| package static var defaultEventLoop: any EventLoop { | ||
| get { | ||
| NIOSingletons.posixEventLoopGroup.next() | ||
| } | ||
| } |
There was a problem hiding this comment.
We must ensure that the eventLoop remains the same, in multiple invocations.
Suggested change
| /// The default EventLoop the Lambda is scheduled on. | |
| package static var defaultEventLoop: any EventLoop { | |
| get { | |
| NIOSingletons.posixEventLoopGroup.next() | |
| } | |
| } | |
| /// The default EventLoop the Lambda is scheduled on. | |
| package static let defaultEventLoop: any EventLoop = NIOSingletons.posixEventLoopGroup.next() |
Add test:
@Test
func testDefaultEventLoopRemainsTheSame() {
let eventLoop = Lambda.defaultEventLoop
#expect(eventLoop === Lambda.defaultEventLoop)
}
fabianfett
reviewed
Sep 4, 2024
fabianfett
reviewed
Sep 5, 2024
fabianfett
reviewed
Sep 5, 2024
fabianfett
reviewed
Sep 5, 2024
fabianfett
reviewed
Sep 5, 2024
|
|
||
| let ipAndPort = runtimeEndpoint.split(separator: ":", maxSplits: 1) | ||
| let ip = String(ipAndPort[0]) | ||
| let port = Int(ipAndPort[1])! |
There was a problem hiding this comment.
we should throw an error here, if the second part is not an Int. .invalidPort.
fabianfett
reviewed
Sep 5, 2024
| let defaultHeaders: HTTPHeaders | ||
| /// These headers must be sent along an invocation or initialization error report | ||
| let errorHeaders: HTTPHeaders | ||
| /// These headers must be sent along an invocation or initialization error report |
fabianfett
reviewed
Sep 5, 2024
fabianfett
reviewed
Sep 5, 2024
… codable initializers.
… update env var missing error name
fabianfett
reviewed
Sep 5, 2024
Comment on lines
163
to
171
| extension NewLambdaRuntime { | ||
| /// Initialize an instance with a ``StreamingLambdaHandler`` in the form of a closure. | ||
| /// - Parameter body: The handler in the form of a closure. | ||
| package convenience init( | ||
| body: @Sendable @escaping (ByteBuffer, LambdaResponseStreamWriter, NewLambdaContext) async throws -> Void | ||
| ) where Handler == StreamingClosureHandler { | ||
| self.init(handler: StreamingClosureHandler(body: body)) | ||
| } | ||
| } |
There was a problem hiding this comment.
this should be in the handler file I guess.
fabianfett
approved these changes
Sep 5, 2024
…wift in AWSLambdaRuntimeCore
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As part of the implementation of the v2 API (#339), a new
LambdaRuntimeClientwas added (#348) and theLambda.runLoopfunction added (#347).This PR adds the
LambdaRuntimewhich initializes aLambdaRuntimeClientand calls theLambda.runLoopfunction with it.Modifications:
LambdaRuntime.defaultEventLoopproperty toLambdaContext.LambdaRuntime.Result:
The runtime can now be used. A handler can be registered with
LambdaRuntimeand the runtime can be start listening for events through therun()function.