-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add runLoop function #347
Merged
Merged
Add runLoop function #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabianfett
reviewed
Aug 29, 2024
fabianfett
reviewed
Aug 29, 2024
fabianfett
reviewed
Aug 29, 2024
fabianfett
reviewed
Aug 29, 2024
fabianfett
reviewed
Aug 30, 2024
fabianfett
reviewed
Aug 30, 2024
fabianfett
reviewed
Aug 30, 2024
fabianfett
reviewed
Aug 30, 2024
fabianfett
reviewed
Aug 30, 2024
fabianfett
reviewed
Sep 2, 2024
fabianfett
reviewed
Sep 2, 2024
fabianfett
reviewed
Sep 2, 2024
fabianfett
approved these changes
Sep 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great change! Thanks for pushing through!
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
As part of the implementation of the new v2 API (#339), the
LambdaRuntimeClientProtocol
was introduced in #344.Building upon it, this PR introduces a static
runLoop
function that implements the runtime loop (fetch the next event -> handle the event -> report the result -> repeat).This function is generic over an object conforming to
LambdaRuntimeClientProtocol
to also allow for mock runtime clients to be used in tests.Modifications:
StreamingLambdaHandler
protocol as detailed in the v2 API proposal (v2 API Proposal Document #339).runLoop
function.Result:
Runtime loop implemented. The library can also be tested more easily, e.g. through a mock runtime client object passed to
runLoop
.