Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: using definite patterns to simplify keybindings #690

Merged
merged 4 commits into from
Feb 17, 2024
Merged

Conversation

sxyazi
Copy link
Owner

@sxyazi sxyazi commented Feb 17, 2024

No description provided.

@sxyazi sxyazi changed the title refactor: using fixed patterns to simplify keybindings refactor: using definite patterns to simplify keybindings Feb 17, 2024
@sxyazi sxyazi merged commit 1ec9943 into main Feb 17, 2024
5 checks passed
@sxyazi sxyazi deleted the pr-dd51f4b5 branch February 17, 2024 11:03
@Brixy
Copy link
Contributor

Brixy commented Feb 17, 2024

Thanks, @sxyazi, for all your work and excellent additions to yazi.

I noticed the following issue with this pull request:

When you do a yp, files vanish. I don’t know what happens technically, but the files are not moved into the trash folder.

@Rolv-Apneseth
Copy link
Contributor

Thanks for reporting @Brixy

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants