custom handling for deft causes duplicate inserts #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get this merged? Without it deft is very frustrating in spacemacs. I can confirm that this change seems to fix the problem and escape still works with either evil escape binding or actually pressing escape. |
|
Can confirm, this seems to fix the double |
|
Sorry for the late merge. |
ghost
mentioned this pull request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as mentioned in syl20bnr/spacemacs#2366, the workaround for deft-mode causes the first char of the escape sequence to be inserted twice (e.g. pressing f causes
ffto appear in the deft filter). Removing the line fixes this behaviour and DEL still works as expected.