Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layer installation instructions #2113

Closed
TheBB opened this issue Jun 25, 2015 · 12 comments
Closed

Layer installation instructions #2113

TheBB opened this issue Jun 25, 2015 · 12 comments

Comments

@TheBB
Copy link
Collaborator

TheBB commented Jun 25, 2015

Most layers tell you to install them by adding a line

(setq-default dotspacemacs-configuration-layers '(blabla))

to the dotfile. There are pretty frequently newbies on gitter making the mistake of taking this literally.

@syl20bnr
Copy link
Owner

syl20bnr commented Jul 9, 2015

Indeed, this point has been mentioned in the past and someone proposed something like:

(setq-default
;; ...
dotspacemacs-configuration-layers
  '(
    ;; ...
    blabla
    ;; ...
  )
;; ...
)

@syl20bnr
Copy link
Owner

Who has the motivation to do this ? :-)))

@d12frosted
Copy link
Collaborator

In my opinion, layers should not ever mention this installation step. In any case, in order to enable layer you have to add it to dotspacemacs-configuration-layers. So probably we have to write information about enabling modules in quick start and be fine with it.

The only thing that comes into my mind is layers like +lang/best-lang-ever. We have to say that you need to add best-lang-ever instead of +lang/best-lang-ever.

@d12frosted
Copy link
Collaborator

Another reason to avoid mentioning this installation step in layer readme file - it's much easier to change it in one place instead of dozens of files.

TheBB added a commit to TheBB/spacemacs that referenced this issue Dec 2, 2015
TheBB added a commit to TheBB/spacemacs that referenced this issue Dec 2, 2015
@StreakyCobra StreakyCobra added this to the release 0.106 milestone Jan 5, 2016
@ghoot
Copy link
Contributor

ghoot commented Jan 6, 2016

To be friendly for beginners, if the default .spacemacs actually listed all available layers, with only some enabled, then with one mention in the Quickstart about where to enable, things should be easier to fathom, and also easier to maintain i.e. new layers don't need to repeat explicit install instructions in the layer docs (unless extra steps required).

However it would mean each new layer addition needs its layer added to the template .spacemacs.

New users often want to try out whats available quickly so listing all layers in the default config facilitates quick experimentation (and visibility) and probably before the new user is familiar with how to use the spacemacs help and docs. By the time you find your feet you manage your layer list however you like.

(setq-default
;; ...
dotspacemacs-configuration-layers
  '(
    all
    layers
    listed
    ;; only
    ;; some
    ;; enabled
    ;; ...
  )
;; ...
)

@robbyoconnor
Copy link
Contributor

@ghoot all fine and dandy but that adds overhead for us to maintain that list.

@ghoot
Copy link
Contributor

ghoot commented Jan 6, 2016

@robbyoconnor yeah. Once its in place to reflect the current layers it could then be a requirement of new layer submissions (low overhead). It's potentially a small tradeoff if there is benefit for newcomers to have easy access to the whole list in their initial config. Given the number of mentions this seems to get, might be worth it as a lo-fi stepping stone.

@robbyoconnor
Copy link
Contributor

I disagree. Don't bloat the template.

@ghoot
Copy link
Contributor

ghoot commented Jan 6, 2016

The template currently is oriented around informing the user of the possible feature settings and giving examples of their use, rather than an optimal config (rightly so). Adding more info re layers in that spirit isn't necessarily bloat.

Users don't explicitly need most of whats in the template as it is, but it's useful to see it there and informative, and layers are one of the key features that people seem to be attracted to. Obviously there's a disconnect for some users in taking the next step and adding layers.

I do agree listing them all is pretty lo-fi, and not pretty. I've seen it done before as a way of helping folk get going.

Anyway, was just thinking out loud.

@robbyoconnor
Copy link
Contributor

I don't agree with THAT solution... currently it's not helpful -- I figured it out...others can too...I assume people aren't idiots...

@ghoot
Copy link
Contributor

ghoot commented Jan 6, 2016

Haha, yeah well there is that :)

@syl20bnr
Copy link
Owner

syl20bnr commented Jan 6, 2016

I took the proposal of #4431 and applied it to all the layers. Should fix the ambiguity.
We can later add an example at one unique place.

Will be part of 0.105.3.

@syl20bnr syl20bnr closed this as completed Jan 6, 2016
@syl20bnr syl20bnr modified the milestones: release 0.201, 0.200 Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants