-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify README regarding the installation of the os x layer #4431
Conversation
#+BEGIN_SRC emacs-lisp | ||
(setq-default dotspacemacs-configuration-layers '(osx)) | ||
#+END_SRC | ||
To use this configuration layer, add it to your =~/.spacemacs=. You will need to add `osx` to the existing list of `dotspacemacs-configuration-layers` in this file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has to be solved in a more general way (i.e. in all layers) as discussed in #2113
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agreed, but until then are we comfortable with newbies continuing to get snagged? This hit me last night and was incredibly frustrating. Until the solution is present, I think we should update the README to assist newcomers as stop gap. We can update the README when #2213 is resolved.
That's my 0.02, I almost dropped Spacemacs altogether over this, it was really frustrating.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The commits that are done now will be available in the 0.106 release (except if @syl20bnr want to hotfix them), what means your change will only be visible by people using the develop
branch, and those ones know how to use layers 😃 There should be enough time before the 0.106 release to solve #2213. As you said it's problematic for the user, so I milestoned it so we don't forget to look at it :-) Keep this issue open… just in case.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool! That makes sense, thanks for giving me a better idea of how the
workflow for this project works! <3
On Tue, Jan 5, 2016 at 4:00 PM, Fabien Dubosson notifications@github.com
wrote:
In layers/osx/README.org
#4431 (comment):@@ -32,11 +32,7 @@ and we encourage you to do so :)
** Layer
-To use this configuration layer, add it to your =~/.spacemacs=
-#+BEGIN_SRC emacs-lisp
- (setq-default dotspacemacs-configuration-layers '(osx))
-#+END_SRC
+To use this configuration layer, add it to your =~/.spacemacs=. You will need to addosx
to the existing list ofdotspacemacs-configuration-layers
in this file.The commits that are done now will be available in the 0.106 release
(except if @syl20bnr https://github.com/syl20bnr want to hotfix them),
what means your change will only be visible by people using the develop
branch, and those ones know how to use layers [image: 😃] There
should be enough time before the 0.106 release to solve #2213
#2213. As you said it's
problematic for the user, so I milestoned it so we don't forget to look at
it :-) Keep this issue open… just in case.—
Reply to this email directly or view it on GitHub
https://github.com/syl20bnr/spacemacs/pull/4431/files#r48902246.
Thank you! 👍 |
This clarifies how to add the
osx
layer to the.spacemacs
file. The existing instructions, despite my best efforts, didn't work, and this seemed confirmed by folks in the chat channel.