Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify README regarding the installation of the os x layer #4431

Closed
wants to merge 1 commit into from
+2 −10
Closed

Clarify README regarding the installation of the os x layer #4431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -136,11 +136,7 @@ the start of this file. That will populate your `~/.emacs.d` directory, which
is what transforms a regular Emacs into Spacemacs.

*After* you have completed the [install process below](#install), it is also
recommended to add the [osx layer][] to your [dotfile][]:

```elisp
(setq-default dotspacemacs-configuration-layers '(osx))
```
recommended to add the [osx layer][] to your [dotfile][]. Install instructions are available in the [osx layer][] documentation.

Note that the `emacs-mac-port` server behaves differently than the regular Emacs
server which in particular **DOES NOT** allow multi-tty if you start GUI i.e.
Expand Down
6 changes: 1 addition & 5 deletions layers/osx/README.org
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,11 +32,7 @@ and we encourage you to do so :)

** Layer

To use this configuration layer, add it to your =~/.spacemacs=

#+BEGIN_SRC emacs-lisp
(setq-default dotspacemacs-configuration-layers '(osx))
#+END_SRC
To use this configuration layer, add it to your =~/.spacemacs=. You will need to add `osx` to the existing list of `dotspacemacs-configuration-layers` in this file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This has to be solved in a more general way (i.e. in all layers) as discussed in #2113

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but until then are we comfortable with newbies continuing to get snagged? This hit me last night and was incredibly frustrating. Until the solution is present, I think we should update the README to assist newcomers as stop gap. We can update the README when #2213 is resolved.

That's my 0.02, I almost dropped Spacemacs altogether over this, it was really frustrating.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commits that are done now will be available in the 0.106 release (except if @syl20bnr want to hotfix them), what means your change will only be visible by people using the develop branch, and those ones know how to use layers 😃 There should be enough time before the 0.106 release to solve #2213. As you said it's problematic for the user, so I milestoned it so we don't forget to look at it :-) Keep this issue open… just in case.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool! That makes sense, thanks for giving me a better idea of how the
workflow for this project works! <3

On Tue, Jan 5, 2016 at 4:00 PM, Fabien Dubosson notifications@github.com
wrote:

In layers/osx/README.org
#4431 (comment):

@@ -32,11 +32,7 @@ and we encourage you to do so :)

** Layer

-To use this configuration layer, add it to your =~/.spacemacs=

-#+BEGIN_SRC emacs-lisp

  • (setq-default dotspacemacs-configuration-layers '(osx))
    -#+END_SRC
    +To use this configuration layer, add it to your =~/.spacemacs=. You will need to add osx to the existing list of dotspacemacs-configuration-layers in this file.

The commits that are done now will be available in the 0.106 release
(except if @syl20bnr https://github.com/syl20bnr want to hotfix them),
what means your change will only be visible by people using the develop
branch, and those ones know how to use layers [image: 😃] There
should be enough time before the 0.106 release to solve #2213
#2213. As you said it's
problematic for the user, so I milestoned it so we don't forget to look at
it :-) Keep this issue open… just in case.

—
Reply to this email directly or view it on GitHub
https://github.com/syl20bnr/spacemacs/pull/4431/files#r48902246.


*** Use with non-US keyboard layouts

Expand Down