new sr-speedbar layer for !tools

[tshemeng]

cause spacemacs already include neotree, so i leave the function spacemacs/sr-speedbar-show-or-hide for users' to binding.

[tshemeng]

[robbyoconnor]

Squash all these commits into one tidy commit...also why are there no evil keybindings?

[robbyoconnor]

bump

[CarlQLange]

God I want this, can it please be merged?

[robbyoconnor]

@blinkd -- rebase and squash this...

[CarlQLange]

I'll probably add some evil bindings in a few days as I use it more often. @blinkd if you're not around anymore I can take care of this for you

[robbyoconnor]

Yeah needs to be rebased and add some keybindings. The fact this was not done is beyond me. Also the fact this hasn't been touched and @blinkd has gone AWOL...have at it @CarlQLange

[edrex]

sr-speedbar windows get replicated geometrically (1 -> 2 -> 4 ...) whenever the helm window comes up. #29 (comment)

Edit: actually I can't reproduce this reliably - it just happens sometimes.

[edrex]

Maybe add (setq speedbar-show-unknown-files t) to show non-code files, as @tuhdo suggested in #29 (comment)

[CarlQLange]

sr-speedbar windows get replicated geometrically (1 -> 2 -> 4 ...) whenever the helm window comes up. #29 (comment)

I haven't seen this.

By the way, just running (evilify) seems to be enough to add suitable vim bindings.

[edrex]

I realized that I hadn't actually enabled the sr-speedbar layer. The included post-init function fixes the cloning issue I was seeing.

It seems like this is a good candidate for replacing NeoTree.

[edrex]

Spoke too soon: I'm still seeing the cloning issue.

This consistently reproduces for me (may depend on frame size):

launch emacs
from spacemacs buffer, SPC : sr-speedbar-toggle, now there's one speedbar window
SPC - now there are two speedbar windows - ESC
SPC - now there are four

[CarlQLange]

I still can't reproduce that at all @edrex. However, it does seem like golden-ratio mode will make strange things happen...

[edrex]

I don't have golden ratio toggled on. It may be a platform specific thing (I'm on a mac), or a difference in our emacs configuration/spacemacs layers. I'm pretty new so my config is close to stock. At least one other person, @syl20bnr, reported experiencing the issue. For me it happens quite a lot (but seems slightly nondeterministic).

[CarlQLange]

want to try and include a video of it? and are you using (spacemacs/sr-speedbar-show-or-hide)?

[edrex]

Oh, I had been using (sr-speedbar-toggle). (sr-speedbar-show-or-hide) is behaving better with Helm.

So yeah.. other than the keybindings, seems good.

[CarlQLange]

nice one.

[CarlQLange]

OK, since I can't change where this PR is coming from, there's a new one here: #3224
this one can be closed.

[TheBB]

Closing this in favour of #3559.