Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sr-speedbar layer #3224

Closed
wants to merge 1 commit into from
Closed

sr-speedbar layer #3224

wants to merge 1 commit into from

Conversation

CarlQLange
Copy link
Contributor

discussion and old PR here: #2002

had to create a new PR because git.

@CarlQLange
sr-speedbar
8fba3aa 
remove unused item from TOC

remove unused item

rename sr-speedbar-show-or-hide to spacemacs/sr-speedbar-show-or-hide

Evilify keybindings

move
@CarlQLange CarlQLange mentioned this pull request Oct 1, 2015
Closed
@punassuming
Copy link
Contributor

Does this show only files, like another project explorer? Can we add a taglist from speedbar as well http://alexott.net/en/writings/emacs-devenv/EmacsCedet.html?

@CarlQLange
Copy link
Contributor Author

nope, it also shows tags. though I don't know about specific compatibility with other projects.

@edrex
Copy link
Contributor

edrex commented Oct 3, 2015

Feedback:

  • Maybe add (setq speedbar-show-unknown-files t) so speedbar shows non-code files (markdown, txt, etc).
  • IMO keybindings should mirror the NeoTree ones, to make transitioning this to the default easier. I guess the main one would be SPC-f-t. SPC-p-t might be possible via anshulverma/projectile-speedbar, but that's for another pull request.

@robbyoconnor robbyoconnor mentioned this pull request Oct 5, 2015
Closed
@robbyoconnor
Copy link
Contributor

#3264 had one thing that was good, a keybinding -- I propose this PR use the SPC a f namespace...I personally don't like it -- I think it belongs under the SPC f namespace. Let's open a dialogue.

@CarlQLange
Copy link
Contributor Author

Yeah, I'd like to shadow the NeoTree ones, to be honest.

@robbyoconnor
Copy link
Contributor

I support that as well. SPC ft sounds reasonable -- but be clear that this layer overwrites that keybinding in the README -- I'd make it bold.

@edrex
Copy link
Contributor

edrex commented Oct 20, 2015

I've been using this, and the only major issue I've found so far:

Given:

  • Two frames, A and B
  • I call spacemacs/sr-speedbar-show-or-hide in A and observe an instance of sr-speedbar is shown in a new window.
  • I switch to B and call spacemacs/sr-speedbar-show-or-hide again.

Observed behavior: sr-speedbar in A is destroyed.
Expected behavior: Instance of sr-speedbar is created in B, distinct from the one in A.

@CarlQLange, I pushed to https://github.com/edrex/spacemacs/tree/sr-speedbar with your commit and one with a keybinding on top of the latest develop if you want to pull that in.

@edrex
Copy link
Contributor

edrex commented Oct 20, 2015

I just dug in with the issue I mentioned above and it happens with sr-speedbar-toggle as well. It seems that Speedbar is designed as a singleton buffer.

With the keybinding, this looks solid :shipit:

@edrex edrex mentioned this pull request Oct 26, 2015
Closed
@robbyoconnor robbyoconnor mentioned this pull request Oct 26, 2015
Closed
@TheBB
Copy link
Collaborator

TheBB commented Oct 26, 2015

Closing this in favour of #3559.

@TheBB TheBB closed this Oct 26, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@CarlQLange @punassuming @edrex @robbyoconnor @TheBB