Added rspec-mode #3067
Added rspec-mode #3067
Conversation
|
This is in the ruby layer -- why do we need this? Just put it in the ruby layer...This doesn't need a new layer... so 👎 -- put it in the ruby layer and rebase. |
|
Also remove the files that do absolutely nothing -- and remove code that does absolutely nothing... |
|
he's got a point, just add this to the ruby layer :) |
|
This still hasn't been addressed...@dcluna :P |
|
I only added this layer because ruby-test-mode's keybindings weren't working for me, so I'd prefer to keep the alternative test commands. And you're absolutely right, adding a new layer is unnecessary, hope it's better now. |
|
It's good :) |
| "mpm" 'rspec-verify-method | ||
| "mpt" 'rspec-toggle-example-pendingness | ||
| )))) | ||
|
|
There was a problem hiding this comment.
Why the mp prefix? Shouldn't this be under the mt prefix per the conventions
|
In addition to this _ALWAYS ADD A README WITH THE KEYBINDINGS!_ |
Why not try to fix it? Perhaps you didn't have them installed properly...or the ruby you were using didn't have the gem available. I suspect this is the case. In addition, see the line comment. |
|
Also, rename this as it is currently inaccurately titled ;) |
|
Rebase again ;) |
|
Now that #3761 has been merged, this one is probably useless and can be closed |
Based on pezra's rspec-mode.