-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change ruby layer to use RSpec-Mode #3761
Conversation
Add more keybinds and update README
Doesn't this force people to use rspec? |
Which I don't think we want to do...that said rspec is the industry standard soo...but still. |
The Python layer has a variable for the test runner to use, so there's precedence for supporting both tools. Then again I'm out of my depth in Ruby, so you rubyists should agree on something. |
For the record: Duplicate of #3067. If this PR get merged, the other one should be closed. |
Just to throw in my opinion. I haven't written Ruby in a while, but I think this seems ok as long as it is overridable if you want to use something else. |
I'm going to add a variable to switch the test runner and update the PR. |
Perhaps instead of |
Thank you 👍 |
I'm unable to get the keybindings for ruby-test to work, even when the project doesn't have rspec in its bundle. I've got the layer in the dotfile as follows
but when I hit |
@karmajunkie I just created a branch that should fix your issue #4251 |
Rebase off develop for #3757