Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change ruby layer to use RSpec-Mode #3761

Closed
wants to merge 3 commits into from

Conversation

alexgirdler
Copy link
Contributor

Rebase off develop for #3757

Add more keybinds and update README
@robbyoconnor
Copy link
Contributor

Doesn't this force people to use rspec?

@robbyoconnor
Copy link
Contributor

Which I don't think we want to do...that said rspec is the industry standard soo...but still.

@TheBB
Copy link
Collaborator

TheBB commented Nov 11, 2015

The Python layer has a variable for the test runner to use, so there's precedence for supporting both tools. Then again I'm out of my depth in Ruby, so you rubyists should agree on something.

@StreakyCobra
Copy link
Contributor

For the record: Duplicate of #3067. If this PR get merged, the other one should be closed.

@codedmart
Copy link

Just to throw in my opinion. I haven't written Ruby in a while, but I think this seems ok as long as it is overridable if you want to use something else.

@alexgirdler
Copy link
Contributor Author

I'm going to add a variable to switch the test runner and update the PR.

@rejeep
Copy link

rejeep commented Nov 19, 2015

Perhaps instead of ruby-use-ruby-test, the name should be more generic, for example: ruby-test-framework. Now it's limited to just Rspec and ruby-test, but there are others.

@syl20bnr
Copy link
Owner

Thank you 👍
I modified it to follow to use the same kind of variable as python, see commit 7e0d8f2
The variable is now ruby-test-runner which takes a symbol, either rspec or ruby-test (default). It should also be possible to use directory local variable to change this settings on a per project basis.
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Nov 27, 2015
@StreakyCobra StreakyCobra mentioned this pull request Nov 27, 2015
@karmajunkie
Copy link

I'm unable to get the keybindings for ruby-test to work, even when the project doesn't have rspec in its bundle. I've got the layer in the dotfile as follows

     (ruby :variables ruby-test-runner 'ruby-test)

but when I hit SPC m t all I get are the rspec versions of the test runner. I've also tried manually overriding the bindings with no results. Am I doing something wrong here?

@alexgirdler
Copy link
Contributor Author

@karmajunkie I just created a branch that should fix your issue #4251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants