Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Swift contribution layer #3464

Closed
wants to merge 1 commit into from
Closed

Swift contribution layer #3464

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Oct 19, 2015

Basic support for Swift (scripting).

Only customization for Spacemacs available is basic support for switching back and forth from the REPL.

@ghost ghost changed the title Swift support initial import Swift contribution layer Oct 19, 2015
@robbyoconnor
Copy link
Contributor

Next time do a search -- duplicate of #2536

@TheBB
Copy link
Collaborator

TheBB commented Oct 20, 2015

This one seems more complete though.

CC @myrjola

@robbyoconnor
Copy link
Contributor

Still -- it seems like duplicate work is better done collaboratively on the same PR -- similar to what happened with #2845

@ghost
Copy link
Author

ghost commented Oct 20, 2015

Hmm... pretty sure I did... anyhow, this one adds the edit-to-repl roundtrip and enables flychecking. How should we proceed?

@robbyoconnor
Copy link
Contributor

@usharf -- Personally (my opinion doesn't carry any weight other than I care) -- I'd leave it. If it literally just duplicated #2536 -- but you added more than that PR had so -- as I said leave it :)

@myrjola
Copy link
Contributor

myrjola commented Oct 21, 2015

@usharf Good work! I closed my pull request as it does bring fever things to the table than yours. Let's hope yours gets merged.

@ghost
Copy link
Author

ghost commented Oct 21, 2015

👍 @myrjola

@d12frosted
Copy link
Collaborator

It has some problems.

  1. You need to set flycheck-swift-sdk-path to something like "/Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.11.sdk". Otherwise you'll see File mode specification error: (void-variable flycheck-swift-sdk-path) on visiting swift file. So it should be part of installation guide.
  2. After that when you visit swift file you'll see another problem - eval-after-load: Symbol's value as variable is void: swift. How to fix that I am not sure :-P

@d12frosted
Copy link
Collaborator

Plus, swift-mode doesn't support swift 2.0, so it's kinda pointless at this point.

hershal added a commit to hershal/spacemacs.d that referenced this pull request Nov 27, 2015
@syl20bnr
Copy link
Owner

syl20bnr commented Dec 4, 2015

At @TheBB request I merged it, if there are some issues with it, don't hesitate to mention them in the README.
Thank you !
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants