Fix smartparens workaround in auto-completion #4050
Conversation
| @@ -263,18 +264,6 @@ | |||
| eshell-mode-hook))) | |||
| :config | |||
| (progn | |||
There was a problem hiding this comment.
[cosmetic] not necessary anymore
There was a problem hiding this comment.
Actually this is not cosmetic, if the argument for :config or any other keyword is multi-line then progn must be used. It makes the code more readable and easier to work with using paredit like commands or navigation. I'll add this to the conventions.
There was a problem hiding this comment.
Yeah but' it's not multiline anymore? Or do you also want the (progn … for single commands?
There was a problem hiding this comment.
Oh you are right, if it is a one liner then it is indeed unnecessary. In this case I usually but the keyword and the argument on the same line.
TheBB
force-pushed
the
autocomp-smartparens
branch
from
447371c
to
13db87c
Compare
|
Updated. :-) |
|
Thank you 👍 |
This will fail if smartparens is excluded.