Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Align-cljlet function to Clojurescript mode #4171

Closed

Conversation

CestDiego
Copy link
Contributor

Derived modes don't inherit evil keybindings from their parents, this is
interesting to note, also it would be so great if we could have a
set-leader-keys macro that could take a list of modes as well.

@StreakyCobra
Copy link
Contributor

Isn't it better to dolist over the keymap instead of having two definition?

Also by convention we use (progn … if there is more than one expression, what is the case with your current code. If you dolist it, it's unnecssary though :-)

@CestDiego
Copy link
Contributor Author

I didn't know we used (progn) if its more than one expression D: I've been not using that since use-package doesn't need it anymore. :(

@StreakyCobra
Copy link
Contributor

The boss decided it there: #4050 (comment) 😄

@nixmaniack
Copy link
Contributor

@StreakyCobra That should definitely be somewhere in the documentation for reference. 😄

@StreakyCobra
Copy link
Contributor

Quoting #4050 (comment):

@syl20bnr: I'll add this to the conventions.

😇

@CestDiego
Copy link
Contributor Author

it does look ugly though T_T I guess he has a point though....

Derived modes don't inherit evil keybindings from their parents, this is
interesting to note, also it would be so great if we could have a
`set-leader-keys` macro that could take a list of modes as well.
@CestDiego
Copy link
Contributor Author

Updated to dolist :)

@StreakyCobra
Copy link
Contributor

👍

@syl20bnr
Copy link
Owner

syl20bnr commented Jan 4, 2016

Hehe I'll add this soon to the conventions :-)
Thank you !
Cherry-picked into develop branch, you can safely delete your branch.

@syl20bnr syl20bnr closed this Jan 4, 2016
@CestDiego CestDiego deleted the add-clojurescript-keybindings branch January 4, 2016 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants