Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RFC] Make TwigComponent "not live" per default ? #1395

Closed
smnandre opened this issue Nov 21, 2023 · 2 comments · Fixed by #1465
Closed

[RFC] Make TwigComponent "not live" per default ? #1395

smnandre opened this issue Nov 21, 2023 · 2 comments · Fixed by #1465
Labels
Feature New Feature Status: Needs Review Needs to be reviewed

Comments

@smnandre
Copy link
Member

POV

I think i create around 50 TwigComponent for 1 LiveComponent
...but my personal experience may not be enough to claim any general case 😅

Current behaviour

During the interaction, the "Make this a live component" defaults to yes.

make-twig-component

Same thing if an arg is given:

 sf make:twig-component FooBaz   

 Make this a live component? (yes/no) [yes]:
 > n

Suggestion

  • use "no" as default (at least when the name is given to the command)
  • create another maker dedicated to the LiveComponent

What do you guys think ?
@jrushlow jrushlow added Feature New Feature Status: Needs Review Needs to be reviewed labels Feb 27, 2024
@jrushlow
Copy link
Collaborator

deferring to @weaverryan as ux is more in his wheelhouse

@weaverryan
Copy link
Member

Agree - defaulting to NOT live makes sense.

jrushlow added a commit to jrushlow/maker-bundle that referenced this issue Feb 28, 2024
@jrushlow
[make:twig-component] default to "no" when asking if is live component
56fb4d9 
fixes symfony#1395
@jrushlow jrushlow mentioned this issue Feb 28, 2024
Merged
jrushlow added a commit to jrushlow/maker-bundle that referenced this issue Feb 28, 2024
@jrushlow
[make:twig-component] default to "no" when asking if is live component
32cbea5 
fixes symfony#1395
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature New Feature Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[make:twig-component] default to "no" when asking if is live component jrushlow/maker-bundle
3 participants
@weaverryan @smnandre @jrushlow