Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[make:twig-component] default to "no" when asking if is live component #1465

Merged
merged 1 commit into from
Feb 28, 2024
Merged

[make:twig-component] default to "no" when asking if is live component #1465

merged 1 commit into from
Feb 28, 2024

Conversation

jrushlow
Copy link
Collaborator

@jrushlow jrushlow commented Feb 28, 2024 •
edited
Loading

  • default to false when asking "Make this a live component"

fixes #1395

@jrushlow jrushlow added Feature New Feature Status: Needs Work Additional work is needed labels Feb 28, 2024
@jrushlow jrushlow added Status: Needs Review Needs to be reviewed and removed Status: Needs Work Additional work is needed labels Feb 28, 2024
@jrushlow jrushlow merged commit 6691a56 into symfony:main Feb 28, 2024
6 checks passed
@jrushlow jrushlow deleted the feature/1395 branch February 28, 2024 18:58
@jrushlow jrushlow mentioned this pull request Mar 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverryan weaverryan weaverryan approved these changes

Assignees
No one assigned
Labels
Feature New Feature Status: Needs Review Needs to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[RFC] Make TwigComponent "not live" per default ?
2 participants
@jrushlow @weaverryan