Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve explanation of code block for bundle removal #3384

Closed
ifdattic opened this issue Dec 25, 2013 · 0 comments
Closed

Improve explanation of code block for bundle removal #3384

ifdattic opened this issue Dec 25, 2013 · 0 comments

Comments

@ifdattic
Copy link
Contributor

In http://symfony.com/doc/current/cookbook/bundles/remove.html#remove-integration-in-other-bundles the following block:

If one bundle relies on another, in most it means that it uses some services from the bundle. Searching for a acme_demo string may help you spot them.

in my opinion can be improved. It talks generally about removing a bundle and then suggest to search for acme_demo, which might be confusing for someone.

I think it would be better if it was reworded to suggest searching an alias of the bundle and then use acme_demo as an example if you wanted to remove AcmeDemoBundle.
@cordoval cordoval mentioned this issue Jan 3, 2014
Merged
weaverryan added a commit that referenced this issue Jan 20, 2014
@weaverryan
minor #3413 [Cookbook][Bundles] improve explanation of code block for…
67b7bbd 
… bundle removal (cordoval)

This PR was merged into the 2.3 branch.

Discussion
----------

[Cookbook][Bundles] improve explanation of code block for bundle removal

| Q             | A                   |
| ---           | ---                 |
| Doc fix?      | yes                 |
| New docs?     | no                  |
| Applies to    | 2.3+                |
| Fixed tickets | #3384               |
| License       | CC-ASA 3.0 Unported |

 Sent using [manager-tools](https://github.com/cordoval/manager-tools)

Commits
-------

a4d804d improve explanation of code block for bundle removal and fix typo
@wouterj wouterj closed this as completed Jan 21, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wouterj @ifdattic