Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Cookbook][Bundles] improve explanation of code block for bundle removal #3413

Conversation

cordoval
Copy link
Contributor

@cordoval cordoval commented Jan 3, 2014

Q A
Doc fix? yes
New docs? no
Applies to 2.3+
Fixed tickets #3384
License CC-ASA 3.0 Unported

Sent using Gush

@cordoval cordoval restored the 3384-improve-explanation-of-code-block-for-bundle-removal branch January 3, 2014 15:47
@@ -96,8 +96,8 @@ rely on the bundle you are about to remove.
.. tip::

If one bundle relies on another, in most it means that it uses some services
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, we have a typo here as well (in most cases it means). Could you possibly add that to your PR (even though it wasn't your mistake)?

Thanks :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry i did not see this, I am in Salt Lake City, Utah now so this escaped me else I would have fixed it, sorry @weaverryan

@weaverryan
Copy link
Member

Thanks Luis!

weaverryan added a commit that referenced this pull request Jan 20, 2014
… bundle removal (cordoval)

This PR was merged into the 2.3 branch.

Discussion
----------

[Cookbook][Bundles] improve explanation of code block for bundle removal

| Q             | A                   |
| ---           | ---                 |
| Doc fix?      | yes                 |
| New docs?     | no                  |
| Applies to    | 2.3+                |
| Fixed tickets | #3384               |
| License       | CC-ASA 3.0 Unported |

 Sent using [manager-tools](https://github.com/cordoval/manager-tools)

Commits
-------

a4d804d improve explanation of code block for bundle removal and fix typo
@weaverryan weaverryan merged commit a4d804d into symfony:2.3 Jan 20, 2014
@cordoval
Copy link
Contributor Author

we gotta get you close PRs with Gush @weaverryan 👶 just gsh p:merge 3413 and the closing message also can be gsh i:close 3384 -m"Thanks Luis!" will save you tons of time cheers!

https://github.com/cordoval/gush

@cordoval cordoval deleted the 3384-improve-explanation-of-code-block-for-bundle-removal branch January 20, 2014 04:00
@wouterj
Copy link
Member

wouterj commented Jan 20, 2014

@cordoval sorry, we choosed to use gh for the docs :)

And please, please stop with advertising of your tool. It becomes annoying...

@cordoval
Copy link
Contributor Author

in that case cool, I did not know it first hand from @weaverryan, thanks for the info @wouterj
and let me remind you about freedom of speech, 👶

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants