Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Best Practice] Add possible note about overriding 3rd party bundles #4635

Closed
weaverryan opened this issue Dec 12, 2014 · 1 comment
Closed

[Best Practice] Add possible note about overriding 3rd party bundles #4635

weaverryan opened this issue Dec 12, 2014 · 1 comment
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.

Comments

@weaverryan
Copy link
Member

There are some very legitimate use-cases for multiple bundles, including (of course) when you're creating something that'll be shared between projects/kernels.

But I think another legitimate use-case is when you're overriding something in a re-usable bundle (e.g. controller). I think a note should be added to the BP about this.

See: https://twitter.com/EnekoOrma/status/543375361875410944

Thanks!
@wouterj
Copy link
Member

wouterj commented Dec 13, 2014

I agree

@weaverryan weaverryan added the actionable Clear and specific issues ready for anyone to take them. label Jan 16, 2015
@wouterj wouterj added the good first issue Ideal for your first contribution! (some Symfony experience may be required) label May 3, 2015
@anacicconi anacicconi mentioned this issue May 23, 2015
Closed
@xabbuh xabbuh added the hasPR A Pull Request has already been submitted for this issue. label May 24, 2015
weaverryan added a commit that referenced this issue Jun 27, 2015
@weaverryan
minor #5290 Overriding 3rd party bundles (anacicconi)
e687f5d 
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes #5290).

Discussion
----------

Overriding 3rd party bundles

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | all
| Fixed tickets | #4635

Commits
-------

58bb3c5 overriding 3rd party bundles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
actionable Clear and specific issues ready for anyone to take them. good first issue Ideal for your first contribution! (some Symfony experience may be required) hasPR A Pull Request has already been submitted for this issue.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@weaverryan @wouterj @xabbuh