Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extended routing cookbook article #5709

Closed
5 tasks done
dbu opened this issue Sep 19, 2015 · 6 comments
Closed
5 tasks done

extended routing cookbook article #5709

dbu opened this issue Sep 19, 2015 · 6 comments
Labels
hasPR A Pull Request has already been submitted for this issue. Routing

Comments

@dbu
Copy link
Contributor

dbu commented Sep 19, 2015

as discussed on twitter a while ago, i am looking into writing a cookbook article on additional things / alternatives to the standard symfony router. i post a sketch for the article here and hope we can discuss it a bit before i write it out in detail:

/cc @weaverryan @wouterj

@weaverryan
Copy link
Member

@dbu I know you've done a lot of non-traditional things with routes, so I think you'd be a perfect person to add this.

I think this should actually be a few cookbook articles - because I want them to be findable, instead of being put together into some big article (e.g. "Custom route loaders and other cool routing stuff"). In other words, we need to think of a few "How do I do X?" titles that you'd use for these articles, and let that drive the content. For example, the first bullet is interesting, but it's not obvious where this would fit or who would come and look for it (but maybe it fits in the routing component?)

@dbu
Copy link
Contributor Author

dbu commented Sep 28, 2015

i was thinking of kind of a "routing book" but your point is valid. i split this into separate points now (edited the description).

if you have further input, please tell. if this is ok, which version should i work on? 2.7? or even 2.3?

@dbu
Copy link
Contributor Author

dbu commented Sep 28, 2015

of course i will do one pull request per bullet point. i can also review the existing docs for 2.7 and create new doc against master - whatever makes the most sense.

@xabbuh
Copy link
Member

xabbuh commented Sep 28, 2015

We should try to create articles that are compatible with Symfony 2.3 (of course we can update them after merging branches up if things are easier/better/whatever in Symfony 2.7 or higher).

@xabbuh xabbuh added the Routing label Sep 28, 2015
@weaverryan
Copy link
Member

👍

@dbu
Copy link
Contributor Author

dbu commented Dec 16, 2015

did PRs for 4 of the 5 points. once done, i could also do #5747 (load routes from service)

wouterj added a commit that referenced this issue Dec 17, 2015
This PR was merged into the 2.3 branch.

Discussion
----------

clarify custom route loader documentation

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | Relates to #5709

Commits
-------

762351e clarify custom route loader documentation
weaverryan added a commit that referenced this issue Jan 10, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

clarify the routing component documentation a bit

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.3+
| Fixed tickets | Relates to #5709

Commits
-------

940fb8f clarify the routing component documentation a bit
weaverryan added a commit that referenced this issue Feb 16, 2016
This PR was merged into the 2.3 branch.

Discussion
----------

mention routing from the database

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | yes
| Applies to    | 2.3+
| Fixed tickets | #2186, relates to #5709

if we merge #6020, we might want to put this as subsection of the extending_routing section

Commits
-------

c458431 mention routing from the database
@javiereguiluz javiereguiluz added the hasPR A Pull Request has already been submitted for this issue. label Jul 5, 2017
xabbuh added a commit that referenced this issue Jul 7, 2017
This PR was merged into the 2.7 branch.

Discussion
----------

Added a help note about translating routes

This will hopefully solve the last missing task of #5709.

Commits
-------

30380e5 Added a help note about translating routes
@xabbuh xabbuh closed this as completed Jul 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hasPR A Pull Request has already been submitted for this issue. Routing
Projects
None yet
Development

No branches or pull requests

4 participants