-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mention routing from the database #6021
Conversation
When all routes are known during deploy time and the number is not too | ||
high, using a :doc:`custom route loader <custom_route_loader>` is the | ||
preferred way to add more routes. When working with just one type of | ||
objects, a slug parameter on the object and the `@ParamConverter` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ParamConverter
should be enclosed with double backticks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice :-) |
@@ -12,3 +12,4 @@ Routing | |||
custom_route_loader | |||
redirect_trailing_slash | |||
extra_information | |||
routing_from_database |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You also need to add a reference to /cookbook/routing/map.rst.inc
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
i updated to all the feedback. anything left to do? |
ping @weaverryan is there a reason to not merge this? happy to correct things if you can tell me what i should change. |
This PR was merged into the 2.3 branch. Discussion ---------- mention routing from the database | Q | A | ------------- | --- | Doc fix? | no | New docs? | yes | Applies to | 2.3+ | Fixed tickets | #2186, relates to #5709 if we merge #6020, we might want to put this as subsection of the extending_routing section Commits ------- c458431 mention routing from the database
@dbu no reason at all - sorry for the delay :) |
if we merge #6020, we might want to put this as subsection of the extending_routing section