Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated to 2.3.0 #2688

Merged
merged 5 commits into from
Jun 12, 2013
Merged

Updated to 2.3.0 #2688

merged 5 commits into from
Jun 12, 2013

Conversation

mykiwi
Copy link
Contributor

@mykiwi mykiwi commented Jun 3, 2013

Q A
Doc fix? yes
New docs? no
Applies to 2.3+


.. tip::

For an exact version, replace `2.2.0` with the latest Symfony version
For an exact version, replace `2.3.0` with the latest Symfony version
(e.g. 2.2.1). For details, see the `Symfony Installation Page`_
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

shouldn't 2.2.1 be replaced, too?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know. Should I write 2.3.1 (or something else)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just remove the complete e,g. 2.2.1 part. We need to update that every time a new version is released

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure. 2.3.1 was a bit confusing as 2.3.0 already is the latest version. Maybe 2.3.0 is sufficient if we just use 2.3 in the install command.

EDIT: didn't see WouterJ's reply when posting this. Probably omitting this completely really was the best solution.

@wouterj
Copy link
Member

wouterj commented Jun 3, 2013

components/using_components should also get updated

@wouterj
Copy link
Member

wouterj commented Jun 3, 2013

and contributing/documentation/overview should also get updated

@mykiwi
Copy link
Contributor Author

mykiwi commented Jun 3, 2013

In contributing/documention/overview, should I just add the branch 2.3 or do more stuff?

@wouterj
Copy link
Member

wouterj commented Jun 3, 2013

Well, I think you should remove the branch versions on line 29 and just have:

multiple branches, corresponding to the different versions of Symfony itself.

weaverryan added a commit that referenced this pull request Jun 12, 2013
@weaverryan weaverryan merged commit 404d417 into symfony:2.3 Jun 12, 2013
@weaverryan
Copy link
Member

Hey Roman!

Thanks for this update - it's very well done! I've merged this in with minor tweaks at sha: 297af3e. Specifically, the 2.3.* version for create-project also does not work for me, so I've changed it to 2.3.0.

Thanks!

weaverryan added a commit that referenced this pull request Jun 8, 2014
…e with the docu... (xabbuh)

This PR was submitted for the master branch but it was merged into the 2.5 branch instead (closes #3882).

Discussion
----------

change version numbers in installation notes to be in line with the docu...

...mented Symfony version

| Q             | A
| ------------- | ---
| Doc fix?      | yes
| New docs?     | no
| Applies to    | 2.5
| Fixed tickets |

This PR updates the version constraints in the installation instructions as described [here](http://symfony.com/doc/current/contributing/documentation/overview.html#when-a-new-branch-is-created-for-a-release):

> Change all version and master references to the correct version (e.g. 2.3). For example, in installation chapters, we reference the version you should use for installation. As an example, see the changes made in PR #2688.

Commits
-------

f77392a change version numbers in installation notes to be in line with the documented Symfony version
@wouterj wouterj mentioned this pull request Jan 5, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants