Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make the docs ready for 2.4 #2690

Closed
wants to merge 2 commits into from
Closed

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jun 3, 2013

Q A
Doc fix? yes
New docs? no
Applies to 2.4+
Fixed tickets -

Things to do when 2.4 is released:

  • update the installation instructions to use 2.4 instead of 2.3 (book/installation, components/using_components and quick_tour/the_big_picture)

I'll rebase it when #2688 is merged

> **Note**
> Unless you're documenting a feature that's new to a specific version of Symfony
> (e.g. Symfony 2.2), all pull requests must be based off of the **2.2**
> branch.
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

backported to 2.2


.. tip::

For an exact version, replace `2.2.0` with the latest Symfony version
(e.g. 2.2.1). For details, see the `Symfony Installation Page`_
For an exact version, replace ``2.3.*`` with the latest Symfony version.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"with the latest Symfony version" is a little bit confusing as 2.3.* already installs the latest version. I would go for "replace 2.3.* with the particular Symfony version".

@weaverryan
Copy link
Member

@wouterj I've just merged in #2688, so you can rebase when you have a chance.

Thanks!

@wouterj
Copy link
Member Author

wouterj commented Jun 12, 2013

@weaverryan done, much less conflicts than I thought :)

@weaverryan
Copy link
Member

Hey Wouter!

According to our new rules, we should not remove these until 2.2 actually reaches its end of life. I think I'd like to follow those rules so we can keep our release process very simple.

I've basically cherry-picked your README change at sha: 788292b.

Thanks!

@weaverryan weaverryan closed this Jun 29, 2013
@wouterj
Copy link
Member Author

wouterj commented Jun 29, 2013

2.2 will be deprecated when 2.4 is released. what about leaving this open and use it in november this year to remove all 2.2 stuff from the docs?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants