Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some version fixes for 2.2 #2692

Closed
wants to merge 1 commit into from
Closed

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Jun 3, 2013

Q A
Doc fix? yes
New docs? no
Applies to 2.2+
Fixed tickets -

@@ -65,7 +65,7 @@ Below is the schedule for the first few versions that use this release model:

This results in very predictable dates and maintenance periods.

* *(special)* Symfony 2.2 will be released at the end of February 2013;
* *(special)* Symfony 2.2 was released at the end of February 2013;
* *(special)* Symfony 2.3 (the first LTS) will be released at the end of May
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2.3 is also released, should be reflected here, I guess

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that should be reflected on the 2.3 branch (did that in #2690 )

@weaverryan
Copy link
Member

@wouterj - can we do anything with this PR? Some of these changes were made in #2690 and there are problems with some others. Specifically, for the URL changes, we just can't do this (https://github.com/symfony/symfony-docs/pull/2692/files#pullrequestreviewcomment-4954866). If we change the 2.2 URLs all to 2.2, then when we merge to 2.3, we'll need to then re-fix all of the URLs to be 2.3 there. Then again when we merge to master :). Of course, when 2.4 is made into a branch, we'll change all of its URLs to be 2.4, but when we merge back up to master, we'll once again have a mess. I think the only solution is to properly fix this with a Sphinx extension, which shouldn't be too hard, we just need to do it :).

So, can we close this PR?

@wouterj
Copy link
Member Author

wouterj commented Jul 30, 2013

@weaverryan instead of creating a sphinx extension, we can use the build-in |version| substitution. But this requires to set the correct version option in the config.

@fabpot is the version option changed when rendering the versions? In other words, are we able to use |version| in the docs?

@weaverryan
Copy link
Member

@wouterj I thought the same thing, but I don't think it's possible. If you put |version| somewhere in the middle of your document, it works great. But as soon as you have it in the URL of a link, it's not parsed. It seems the URL for a link is read completely statically - no expressions are parsed. For example:

.. _`Twig Bridge`: https://github.com/symfony/symfony/tree/|version|/src/Symfony/Bridge/Twig

If you can find a way around this, let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants