Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing backtick #4134

Closed
wants to merge 1 commit into from
Closed

Missing backtick #4134

wants to merge 1 commit into from

Conversation

Baptouuuu
Copy link
Contributor

Q A
Doc fix? yes
New docs? no
Applies to 2.5+
Fixed tickets

@xabbuh
Copy link
Member

xabbuh commented Aug 16, 2014

👍

@weaverryan
Copy link
Member

Hey @Baptouuuu!

I have the same problem here as #4130. Can you rebase?

git fetch upstream
git checkout typo-2.5
git rebase --onto upstream/2.3 upstream/2.5
git push origin typo-2.5 --force

Thanks!

@Baptouuuu
Copy link
Contributor Author

@weaverryan done

@wouterj
Copy link
Member

wouterj commented Aug 17, 2014

Hmm, ryan, I think you've suggested something wrong. This PR should be merged into the 2.5 branch, not 2.3.

@Baptouuuu I'm afraid you have to execute the same commands again, but than with git rebase --onto upstream/2.5 upstream/2.3

@weaverryan
Copy link
Member

Unless I'm missing something, it looks like there are no changes in this PR anymore! Perhaps the backtick was added and so now is no longer needed?

Thanks!

@xabbuh
Copy link
Member

xabbuh commented Aug 22, 2014

@weaverryan I don't think so. There haven't been any related changes recently.

@javiereguiluz
Copy link
Member

I think @weaverryan is right. The changes made by this PR no longer relate to a missing backtick. Should we close this issue then?

@xabbuh
Copy link
Member

xabbuh commented Sep 8, 2014

@javiereguiluz I'm pretty sure that the change was necessary and that it wasn't covered anywhere else. Though I don't remember what it was. :(

@javiereguiluz
Copy link
Member

@xabbuh if nobody know what this issue is about, we should close it. And don't worry about this mysterious error. If it's important, someone else will open a new issue in the future.

@wouterj
Copy link
Member

wouterj commented Sep 8, 2014

Found it :) #4212

@javiereguiluz
Copy link
Member

Great detective work Wouter!

weaverryan added a commit that referenced this pull request Sep 15, 2014
This PR was merged into the 2.5 branch.

Discussion
----------

Missing backtick, thanks to @Baptouuuu

See #4134

Commits
-------

dadaea3 Missing backtick, thanks to @Baptouuuu
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants