-
-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Missing backtick #4134
Missing backtick #4134
Conversation
Baptouuuu
commented
Aug 16, 2014
Q | A |
---|---|
Doc fix? | yes |
New docs? | no |
Applies to | 2.5+ |
Fixed tickets |
👍 |
Hey @Baptouuuu! I have the same problem here as #4130. Can you rebase? git fetch upstream
git checkout typo-2.5
git rebase --onto upstream/2.3 upstream/2.5
git push origin typo-2.5 --force Thanks! |
@weaverryan done |
Hmm, ryan, I think you've suggested something wrong. This PR should be merged into the 2.5 branch, not 2.3. @Baptouuuu I'm afraid you have to execute the same commands again, but than with |
Unless I'm missing something, it looks like there are no changes in this PR anymore! Perhaps the backtick was added and so now is no longer needed? Thanks! |
@weaverryan I don't think so. There haven't been any related changes recently. |
I think @weaverryan is right. The changes made by this PR no longer relate to a missing backtick. Should we close this issue then? |
@javiereguiluz I'm pretty sure that the change was necessary and that it wasn't covered anywhere else. Though I don't remember what it was. :( |
@xabbuh if nobody know what this issue is about, we should close it. And don't worry about this mysterious error. If it's important, someone else will open a new issue in the future. |
Found it :) #4212 |
Great detective work Wouter! |
This PR was merged into the 2.5 branch. Discussion ---------- Missing backtick, thanks to @Baptouuuu See #4134 Commits ------- dadaea3 Missing backtick, thanks to @Baptouuuu