Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 'attr' option to the Textarea options list #4152

Closed
wants to merge 1 commit into from
Closed

Adding 'attr' option to the Textarea options list #4152

wants to merge 1 commit into from

Conversation

ronanguilloux
Copy link
Contributor

Q A
Doc fix? yes
New docs? nope
Applies to all?
Fixed tickets ?

attr is a quite useful option, but not yet listed here, so I added it.
BTW, the attr.rst.inc file already includes an attr conf. example concerning textareas.

`attr` is a quite useful option, but not yet listed here. BTW, the `attr.rst.inc` file already includes an `attr` conf. example concerning textareas.
@weaverryan
Copy link
Member

Hey @ronanguilloux!

Hmm, you're right! This is one of the more important options, and we're actually missing it on every field (in a few cases, like "collection", that's ok - I don't think attr makes sense for it).

I think we should add this option to ever field that it makes sense to. That's a bit of work. Would you like to do it? If not, no worries - I'll merge this PR and we'll add it in another.

Thanks!

@weaverryan
Copy link
Member

Also, if you do add it to the other fields, we'll need this PR to be rebased onto the 2.3 branch (else we'll likely get merge conflicts trying to merge this into 2.3): #4134 (comment)

Thanks!

@stof
Copy link
Member

stof commented Aug 23, 2014

it makes sense even for the collection type too

@xabbuh
Copy link
Member

xabbuh commented Aug 23, 2014

This is related to #2360.

@weaverryan weaverryan mentioned this pull request Aug 25, 2014
3 tasks
@weaverryan
Copy link
Member

I'll leave adding this to all the other types to another PR (I mentioned it explicitly in #2360). Thanks Ronan!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants