Inline condition removed for easier reading #4387
Conversation
Previous inline condition would cause confusion or trigger notifications in IDE (Netbeans,...)
| @@ -404,7 +404,8 @@ Next, refactor the ``Document`` class to take advantage of these callbacks:: | |||
| */ | |||
| public function removeUpload() | |||
| { | |||
| if ($file = $this->getAbsolutePath()) { | |||
| $file == $this->getAbsolutePath(); | |||
There was a problem hiding this comment.
Here you have to use an assignment but no comparison operator.
There was a problem hiding this comment.
haha we'll get it right soon !
|
Hi i see that i referenced this PR from a commit, is that enough for it to be merged ? sorry i'm new ... |
|
@acidjames you should put the required changes in the branch that is related to this PR: The PR can only be merged by people with push access (basically @weaverryan and me). I'll merge your PR once you did the required changed. Btw, if you need more help, don't hesitate to ask :) |
|
@wouterj i've been trying to access acidjames:patch-1 with the official Github client without success, should i be using this client or something else ? |
|
@acidjames you can go to http://github.com/acidjames/symfony-docs/tree/patch-1 Then navigate to the file and click on "edit", make the changes and commit them. |
| @@ -404,7 +404,8 @@ Next, refactor the ``Document`` class to take advantage of these callbacks:: | |||
| */ | |||
| public function removeUpload() | |||
| { | |||
| if ($file = $this->getAbsolutePath()) { | |||
| $file = $this->getAbsolutePath(); | |||
| + if ($file) { | |||
|
Sorry guys, i'll do better next time i promise ! |
|
No worries, we are here to help you. You did a great job, thanks! |
This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes #4387). Discussion ---------- Inline condition removed for easier reading Previous inline condition would cause confusion or trigger notifications in IDE (Netbeans,...) Commits ------- b98f5e8 Inline condition removed for easier reading
Previous inline condition would cause confusion or trigger notifications in IDE (Netbeans,...)