Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inline condition removed for easier reading #4387

Closed
wants to merge 3 commits into from
Closed

Inline condition removed for easier reading #4387

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d477694
Inline condition removed for easier reading
acidjames Oct 28, 2014
a4535d7
assignment typo
acidjames Oct 30, 2014
39b6156
plus sign removed
acidjames Oct 31, 2014
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion cookbook/doctrine/file_uploads.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -404,7 +404,8 @@ Next, refactor the ``Document`` class to take advantage of these callbacks::
*/
public function removeUpload()
{
if ($file = $this->getAbsolutePath()) {
$file == $this->getAbsolutePath();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you have to use an assignment but no comparison operator.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(sorry, I made that typo too)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha we'll get it right soon !

+ if ($file) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

double ++ here. You should remove the + in your code

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The + has to be removed.

unlink($file);
}
}
Expand Down