Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Normalization of method listings #4539

Merged
merged 5 commits into from
Dec 20, 2014
Merged

Conversation

pedronofuentes
Copy link
Contributor

Q A
Doc fix? no
New docs? no
Applies to all
Fixed tickets fixes #3903

@pedronofuentes
Copy link
Contributor Author

Work in progress. I'm still looking for other listings to normalize them.

@pedronofuentes pedronofuentes changed the title Issue 3903 Normalization of method listings Nov 29, 2014
@pedronofuentes
Copy link
Contributor Author

Sure!

I'm reviewing the docs looking for them. Thank you for the list :)

@xabbuh
Copy link
Member

xabbuh commented Nov 29, 2014

Looks good so far. Let's see what Travis reports.

@pedronofuentes
Copy link
Contributor Author

Thanks. I have pending to look for more fixes in other parts of the docs.


Pedro

On Sat, Nov 29, 2014 at 4:28 PM, Christian Flothmann
notifications@github.com wrote:

Looks good so far. Let's see what Travis reports.

Reply to this email directly or view it on GitHub:
#4539 (comment)

@xabbuh
Copy link
Member

xabbuh commented Dec 1, 2014

@pedronofuentes Travis is happy with your changes. :) Just let us know when you think you're finished or when you need additional help.

@xabbuh
Copy link
Member

xabbuh commented Dec 2, 2014

@pedronofuentes I think it's okay to merge this now.

@wouterj What do you think?

@javiereguiluz
Copy link
Member

I'd love to see this PR merged. @wouterj is there anything left that should be completed? Thanks!

@xabbuh
Copy link
Member

xabbuh commented Dec 17, 2014

@wouterj Can you merge as is or do we need a rebase?

@wouterj
Copy link
Member

wouterj commented Dec 17, 2014

I can't merge this using GH atm, it would be easier if it was rebased.

wouterj added a commit that referenced this pull request Dec 17, 2014
…tes)

This PR was squashed before being merged into the 2.5 branch (closes #4551).

Discussion
----------

Normalize the method listings on version 2.5

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    | 2.5
| Fixed tickets | #3903

This pull request is related with #4539. Normalizes listings from 2.5

Commits
-------

2665407 Normalize the method listings on version 2.5
@xabbuh
Copy link
Member

xabbuh commented Dec 17, 2014

@pedronofuentes Can you rebase here?

@pedronofuentes
Copy link
Contributor Author

@xabbuh of course.

@pedronofuentes
Copy link
Contributor Author

@xabbuh done!

@javiereguiluz
Copy link
Member

@pedronofuentes thanks for your great work removing these inconsistencies!

@weaverryan weaverryan merged commit 3fd3963 into symfony:2.3 Dec 20, 2014
weaverryan added a commit that referenced this pull request Dec 20, 2014
This PR was merged into the 2.3 branch.

Discussion
----------

Normalization of method listings

| Q             | A
| ------------- | ---
| Doc fix?      | no
| New docs?     | no
| Applies to    | all
| Fixed tickets | fixes #3903

Commits
-------

3fd3963 Changed to definition lists from Book section
dda1905 Changed to definition lists
3649bdb Fixed heading capitalization to follow the standards
6b68e48 Changed paragraph to heading
1d571ca Changed unordered list to definition list
@weaverryan
Copy link
Member

Wow, great work on this - this is a huge amount of changes. Thanks for doing this and everyone for searching through to find the occurrences. Woot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants