Ref #3903 - Normalize methods listings #4550
Conversation
|
@wouterj what do you think about this PR considering that there are other related PR about normalizing method listings? |
|
Most of these changes are already included in #4539. @pedronofuentes Can you maybe update your pull request to include the missing changes from this one? |
|
Ok |
|
@pedronofuentes Thank you and sorry for the additional work. |
|
@pedronofuentes Did you manage to include the missing changes into #4539 or should we do a rebase here to get the rest merged? |
|
@xabbuh I'm sorry, I couldn't. Can I help somehow? |
|
@pedronofuentes Don't worry. :) We can still merge this one. @ternel Are you able to rebase your pull request? |
ternel
force-pushed
the
normalize_method_listings
branch
2 times, most recently
from
f88d8af to
9ee8a1f
Compare
|
It should be ok @xabbuh :) |
| @@ -132,6 +132,7 @@ an array. A few methods exist for "Bag" management: | |||
| Session Metadata | |||
| ................ | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Can you reduce them to one blank line?
ternel
force-pushed
the
normalize_method_listings
branch
from
9ee8a1f to
0912b19
Compare
|
@ternel Thank you! Looks good. 👍 |
|
Thx for your review :) |
|
It's really great to see many people working together to fix such a broad issue! Thanks for rebasing, Benjamin. You made my life a lot easier |
This PR was squashed before being merged into the 2.3 branch (closes #4550). Discussion ---------- Ref #3903 - Normalize methods listings | Q | A | ------------- | --- | Doc fix? | yes | New docs? | no | Applies to | 2.3+ | Fixed tickets | #3903 I only did this on methods listings which have some informations about the methods. (ie. I didn't change anything on this page: http://symfony.com/doc/current/contributing/code/conventions.html#method-names) Commits ------- 9039e5b Ref #3903 - Normalize methods listings
I only did this on methods listings which have some informations about the methods. (ie. I didn't change anything on this page: http://symfony.com/doc/current/contributing/code/conventions.html#method-names)