Tried to clarify private services #4656
Merged
+9
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this will result in an inlined instantiation (e.g. ``new PrivateFooBar()``) | ||
| inside this other service, making it publicly unavailable at runtime. | ||
| What makes private services special, is that they are converted from services | ||
| to inlined instantiation (e.g. ``new PrivateThing()``) when they are only |
There was a problem hiding this comment.
Would it be OK to mention that Symfony does this for performance reasons?
There was a problem hiding this comment.
i think we have to mention that it is JUST for performance reason.
|
I applied the comments, thanks! |
|
awesome 👍 |
weaverryan
added a commit
that referenced
this pull request
Jan 3, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Tried to clarify private services | Q | A | --- | --- | Doc fix? | yes | New docs? | kind of | Applies to | all | Fixed tickets | #4524 It was a though one to describe, as I wanted to make it clear and short. I'm really happy if people can review this and provide other, better, alternatives! Commits ------- d89ad21 Tried to clarify private services
weaverryan
added a commit
that referenced
this pull request
Jan 3, 2015
|
Hi guys! I merged this in, but then realized I wanted to make some changes above these changes and reorganize a few things. Please check out #4748. Thanks! |
weaverryan
added a commit
that referenced
this pull request
Jan 3, 2015
weaverryan
added a commit
that referenced
this pull request
Jan 3, 2015
weaverryan
added a commit
that referenced
this pull request
Jan 4, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Re-reading private service section | Q | A | --- | --- | Doc fix? | yes | New docs? | kind of | Applies to | all | Fixed tickets | n/a Hi guys! This follows #4656. I merged that, but then realized that if you read the wider section, the top was still talking about private services as if their benefit was to *not* allow fetching directly (whereas the true emphasis now is on performance, and how `get()` may or may not work. Thanks! Commits ------- 8f5e210 Re-wording based on Wouter's recommendation 0f86a86 [#4656] Re-reading private service section
weaverryan
added a commit
that referenced
this pull request
Jan 4, 2015
* 2.3: Re-wording based on Wouter's recommendation update text to use SetHandler (not ProxyPassMatch) cache_csrf_form [Book][Security] Add isPasswordValid doc as in 2.6 [#4656] Re-reading private service section
weaverryan
added a commit
that referenced
this pull request
Jan 4, 2015
* 2.5: Re-wording based on Wouter's recommendation update text to use SetHandler (not ProxyPassMatch) cache_csrf_form [Book][Security] Add isPasswordValid doc as in 2.6 [#4656] Re-reading private service section
weaverryan
added a commit
that referenced
this pull request
Jan 4, 2015
* 2.7: Re-wording based on Wouter's recommendation update text to use SetHandler (not ProxyPassMatch) cache_csrf_form [Book][Security] Add isPasswordValid doc as in 2.6 [#4656] Re-reading private service section Update code example to fit description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was a though one to describe, as I wanted to make it clear and short. I'm really happy if people can review this and provide other, better, alternatives!