Re-reading private service section #4748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverryan
changed the title
weaverryan
force-pushed
the
private-services
branch
from
0a01ffa to
8fb3ce0
Compare
weaverryan
force-pushed
the
private-services
branch
from
8fb3ce0 to
0f86a86
Compare
| *might* fail, see the explaination above):: | ||
| What makes private services special is that they are converted from services | ||
| to inlined instantiations (e.g. ``new PrivateThing()``) if they are only | ||
| injected once. This increases the container's performance. |
There was a problem hiding this comment.
well I know it isn't very great english (well, at least it isn't very good dutch), I like "What makes private services special is that, if they are only injected once, they are converted from services to inlined instantiations (e.g. new PrivateThing())." more
There was a problem hiding this comment.
It does sound better to me - good suggestion :)
weaverryan
added a commit
that referenced
this pull request
Jan 4, 2015
This PR was merged into the 2.3 branch. Discussion ---------- Re-reading private service section | Q | A | --- | --- | Doc fix? | yes | New docs? | kind of | Applies to | all | Fixed tickets | n/a Hi guys! This follows #4656. I merged that, but then realized that if you read the wider section, the top was still talking about private services as if their benefit was to *not* allow fetching directly (whereas the true emphasis now is on performance, and how `get()` may or may not work. Thanks! Commits ------- 8f5e210 Re-wording based on Wouter's recommendation 0f86a86 [#4656] Re-reading private service section
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi guys!
This follows #4656. I merged that, but then realized that if you read the wider section, the top was still talking about private services as if their benefit was to not allow fetching directly (whereas the true emphasis now is on performance, and how
get()may or may not work.Thanks!