Minor improvement for symfony-installer with LTS #5032
Conversation
|
note for maintainers, this should be merged in the 2.3 branch (and it should be flagged as WCM for now) |
xabbuh
changed the title
|
@94noni Thank your for creating this pull request. FYI, I prefixed the PR title with "[WCM]" to indicate that we are waiting for your PR to be merged into the Symfony Installer code. |
| @@ -98,6 +98,16 @@ number as the second argument of the ``new`` command: | |||
| # Windows | |||
| c:\projects\> php symfony.phar new my_project_name 2.3.23 | |||
|
|
|||
| If you want your project to be based on the last Symfony LTS version, pass ``lts`` as the second argument of the ``new`` command: | |||
There was a problem hiding this comment.
Can you please wrap lines after the first word that crosses the 72nd character?
based on the symfony-installer PR symfony/symfony-installer#105
|
@xabbuh ok for the PR |
This PR was squashed before being merged into the 1.0-dev branch (closes #105). Discussion ---------- Allow last LTS version to be installed. Hi, I just wanted to add the possibility to install the latest Symfony LTS version directly via the installer (new command). Docs PR symfony/symfony-docs#5032 Feedbacks welcome :) Commits ------- 6c08849 Allow last LTS version to be installed.
xabbuh
changed the title
| @@ -98,6 +98,17 @@ number as the second argument of the ``new`` command: | |||
| # Windows | |||
| c:\projects\> php symfony.phar new my_project_name 2.3.23 | |||
|
|
|||
| If you want your project to be based on the last Symfony LTS version, pass | |||
There was a problem hiding this comment.
Is it better to use "latest" instead of "last"?
There was a problem hiding this comment.
Latest could be interpreted as "they are a lot of LTS versions", but there is only one
For me last is ok, or nothing at all
There was a problem hiding this comment.
Well, if you look at each patch version as its own version, there are a lot of LTS versions. However, at least this will be true when Symfony 2.7 is released because we then have two LTS versions.
There was a problem hiding this comment.
IIRC what my English teachers told me, last would mean that there won't be any other LTS version after this one, which is wrong.
But I will let a native speaker confirm this
There was a problem hiding this comment.
I understand your point of view
Can you confirm that https://github.com/symfony/symfony-installer/blob/master/src/Symfony/Installer/NewCommand.php#L223 will download automatically the 2.7 when it will be published, even if the 2.3 will still be maintained?
If yes, latest is the best option imo
There was a problem hiding this comment.
@94noni I can confirm that lts will always be the most recent LTS version (2.3 today and 2.7 in a few months). This version switch will be transparent to the installer and it will be done immediately after the new LTS version is published.
|
ping @xabbuh cc @stof @javiereguiluz |
|
👍 Looks great @94noni! |
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #5032). Discussion ---------- Minor improvement for symfony-installer with LTS Minor improvement for symfony-installer with LTS based on the symfony-installer PR symfony/symfony-installer#105 Commits ------- 18c08f3 Better wording 8e41e73 Minor improvement for symfony-installer with LTS
|
Great feature and great addition. Thanks so much for this Antoine! I also added a link for "lts" to the releases page at sha: 912682a Cheers! |
Minor improvement for symfony-installer with LTS
based on the symfony-installer PR symfony/symfony-installer#105