Allow last LTS version to be installed. #105
Conversation
| } | ||
|
|
||
| // Get the Symfony versions list (http://symfony.com/versions.json) | ||
| $versionsList = $this->getVersionsList(); |
There was a problem hiding this comment.
this is no loading the version list in cases where it is not needed (passing an exact version), which is wrong. The HTTP request should be done only when needed
There was a problem hiding this comment.
Yes of course, going to fetch+cache them
There was a problem hiding this comment.
Well, this is still only necessary if the user doesn't pass a version number in the 2.M.N format (to either fetch the latest patch version, the LTS version or the latest stable version).
There was a problem hiding this comment.
@94noni what you should do is move this call inside the if (self::VERSION_LTS === $this->version) { conditional (and add it again in the place where you removed it). The call won't be done twice anyway because the JSON gives you the exact version for the LTS, not the branch
There was a problem hiding this comment.
Unless symfony.com plans to propose a proper "standard" download link for the LTS version, this behavior seems correct to me.
|
If you want, we can make |
|
@javiereguiluz exactly what i asked for @stof
|
|
This could reduce this PR to two lines of code, I think it's worth the cost 😃 |
|
OK. The |
|
@javiereguiluz Will that be the latest LTS once Symfony 2.7 is released? |
|
@xabbuh yes. It will always point to the most recent LTS version, whichever it is. |
|
@94noni can you update the PR so that it simply handle |
|
Thank all of you, waiting your go to change this (and PR on the related symfony documentation) |
|
Can you revert the other changes being done here to really keep it a 2-line patch (well, maybe 4 because of formatting) |
|
@stof PR finalized, much cleaner with the symfony.com lts version supported now |
|
👍 |
|
Just forget the read me. Updated now |
|
The special |
|
👍 then |
|
Cool :) |
|
Thanks @94noni! It took me a lot of time to merge this, but it's finally done :) |
based on the symfony-installer PR symfony/symfony-installer#105
This PR was submitted for the 2.6 branch but it was merged into the 2.3 branch instead (closes #5032). Discussion ---------- Minor improvement for symfony-installer with LTS Minor improvement for symfony-installer with LTS based on the symfony-installer PR symfony/symfony-installer#105 Commits ------- 18c08f3 Better wording 8e41e73 Minor improvement for symfony-installer with LTS
Hi,
I just wanted to add the possibility to install the latest Symfony LTS version directly via the installer (new command).
Docs PR symfony/symfony-docs#5032
Feedbacks welcome :)