Order takes one argument, 'allow,deny', 'deny,allow', or 'mutual-failure... #5197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure' Syntax error : order takes one argument, 'allow,deny', 'deny,allow', or 'mutual-failure'
|
👍 good catch @fpondepeyre |
fpondepeyre
changed the title
|
@fpondepeyre In #5203 (comment) it was suggested to uppercase the option value to.Will you be able to make this change? |
|
ping @fpondepeyre :) |
|
I'm closing this PR in favor of #5203. It was just a little more complete and because we get a lot of bug fixes about this problem, I want to fix this bug as quick as possible. Anyway, thanks for noticing and fixing this bug @fpondepeyre! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Syntax error : order takes one argument, 'allow,deny', 'deny,allow', or 'mutual-failure'